Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a single radius version of CanvasRenderingContext2D.roundRect #7592

Closed
mysteryDate opened this issue Feb 8, 2022 · 3 comments
Closed

Add a single radius version of CanvasRenderingContext2D.roundRect #7592

mysteryDate opened this issue Feb 8, 2022 · 3 comments
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: canvas

Comments

@mysteryDate
Copy link
Contributor

As the spec is currently written:

ctx.roundRect(10, 10, 100, 100, [10]);

produces a rounded rectangle with all corners of radius 10 but:

ctx.roundRect(10, 10, 100, 100, 10);

throws an error. I don't see a reason why we can't also support the latter case. I've already written the spec change here:

mysteryDate@c8475c3
Kaiido added a commit to Kaiido/roundRect that referenced this issue Feb 10, 2022
@Kaiido
Allow the use of a single double or DOMPointInit
244a716 
See whatwg/html#7592
@Kaiido Kaiido reopened this Feb 13, 2022
@annevk annevk added addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: canvas labels Feb 14, 2022
@annevk
Copy link
Member

annevk commented Feb 14, 2022

cc @whatwg/canvas

@kdashg
Copy link

kdashg commented Feb 14, 2022

This sounds reasonable to me.

@mysteryDate
Copy link
Contributor Author

It was also brought up in this issue:
fserb/canvas2D#20

This was referenced Feb 15, 2022
Merged
Closed
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@xiaochengh @mfreed7
Make style element script-blocking only if its media="" matches
7889826 
Fixes whatwg#7592.
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@mysteryDate @mfreed7
Add a single radius version of canvas roundRect()
cb94238 
Closes whatwg#7592.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: canvas
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kdashg @annevk @mysteryDate @Kaiido