Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedWorker should be partitioned by StorageKey #7913

Open
wanderview opened this issue May 10, 2022 · 1 comment
Open

SharedWorker should be partitioned by StorageKey #7913

wanderview opened this issue May 10, 2022 · 1 comment
Labels
topic: workers

Comments

@wanderview
Copy link
Member

Currently step 11.2 of:

https://html.spec.whatwg.org/#dom-sharedworker

Only compares origin, name, etc when looking for an existing SharedWorker instance. This should check StorageKey instead of origin in order to support 3P partitioning.
@wanderview
Copy link
Member Author

wanderview commented Jun 8, 2022 •
edited
Loading

There is an added problem here. The top-level origin is not set on the environment settings object for shared workers. This will result in the worker environment returning the wrong storage key.

See step 7 of: https://html.spec.whatwg.org/#script-settings-for-workers

wanderview added a commit to wanderview/html that referenced this issue Jun 8, 2022
@wanderview
Compare against storage key when creating a SharedWorker. (whatwg#7913)
b9a6726
wanderview added a commit to wanderview/html that referenced this issue Jun 10, 2022
@wanderview
Compare against storage key when creating a SharedWorker. (whatwg#7913)
c2d2f9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: workers
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wanderview @annevk