Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<link> base URL should use document's base URL, not document's URL #8330

Closed
domenic opened this issue Sep 29, 2022 · 1 comment · Fixed by #9236
Closed

<link> base URL should use document's base URL, not document's URL #8330

domenic opened this issue Sep 29, 2022 · 1 comment · Fixed by #9236
Assignees
@noamr
Labels
topic: link

Comments

@domenic
Copy link
Member

domenic commented Sep 29, 2022

https://html.spec.whatwg.org/#create-link-options-from-element seems incorrect. /cc @noamr

I think for HTTP Link headers, the difference is not observable, since there will be no <base> elements at the time headers are processed, and about:srcdoc and about:blank documents cannot have Link headers. But, it might be good to update them for consistency.
@ninadvyas

This comment was marked as spam.

Sign in to view
@noamr noamr mentioned this issue Apr 30, 2023
Merged
4 tasks
noamr added a commit to noamr/html that referenced this issue Apr 30, 2023
@noamr
Use base URL instead of URL for links
048a15e 
Closes whatwg#8330
domenic pushed a commit that referenced this issue May 2, 2023
@noamr
Use document's base URL when resolving <link> hrefs
b6d8428 
This regressed at some point in the past with the various refactorings to the link processing model. Closes #8330.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noamr noamr

Labels
topic: link
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use base URL instead of URL for links noamr/html
3 participants
@noamr @domenic @ninadvyas