Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: do not use "get an output encoding" for decoding #1118

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Regression: do not use "get an output encoding" for decoding #1118

merged 1 commit into from
Apr 25, 2016

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 24, 2016 •
edited by zcorpan
Loading

In 6a31c26 I applied “get an output
encoding” a bit enthusiastically, which gives the wrong result for the
replacement encoding. It is only to be used when encoding (e.g., <form>
submission and URLs), not decoding.

This fixes the regression part of #1077.

@annevk
Regression: do not use "get an output encoding" for decoding
074200c 
In 6a31c26 I applied “get an output
encoding” a bit enthusiastically, which gives the wrong result for the
replacement encoding. It is only to be used when encoding (e.g., <form>
submission and URLs), not decoding.

This fixes the regression part of #1077.
@zcorpan
Copy link
Member

zcorpan commented Apr 25, 2016

LGTM

@annevk annevk merged commit c36f738 into master Apr 25, 2016
@annevk annevk deleted the outputencoding branch April 25, 2016 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annevk @zcorpan