Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realm used "When a WebSocket message has been received" #1959

Closed
Ms2ger opened this issue Oct 24, 2016 · 4 comments
Closed

Realm used "When a WebSocket message has been received" #1959

Ms2ger opened this issue Oct 24, 2016 · 4 comments
Assignees
@domenic
Labels
clarification Standard could be clearer topic: events topic: multiple globals

Comments

@Ms2ger
Copy link
Member

Ms2ger commented Oct 24, 2016

https://html.spec.whatwg.org/multipage/comms.html#feedback-from-the-protocol

When a WebSocket message has been received

… we create a Blob without defining the global object it should be associated with.

CC @bzbarsky @annevk @domenic
@bzbarsky
Copy link
Contributor

Same thing for the ArrayBuffer case.

@domenic
Copy link
Member

domenic commented Oct 24, 2016

I mean, we do this all over the spec, but I'll take this as an indication that this particular case is causing implementer pain and is worth fixing.

@domenic domenic self-assigned this Oct 24, 2016
@bzbarsky
Copy link
Contributor

Ms2ger is trying to implement some of this stuff in Servo and running into all sorts of underdefined cases...

@domenic domenic mentioned this issue Oct 24, 2016
Merged
domenic added a commit that referenced this issue Oct 24, 2016
@domenic
Specify the realm used for WebSocket-created Blobs and ArrayBuffers
f1624ec 
Fixes part of #1959.
@domenic domenic mentioned this issue Oct 24, 2016
Merged
@domenic
Copy link
Member

domenic commented Oct 24, 2016

We also need to specify the realm for the MessageEvent created. That is blocked on whatwg/dom#349 and #1935 landing. In the meantime, #1964 is up for the blob and arraybuffer, but I'll leave this open until all are fixed.

@domenic domenic added the clarification Standard could be clearer label Oct 24, 2016
domenic added a commit that referenced this issue Oct 25, 2016
@domenic
Specify the realm used for WebSocket-created Blobs and ArrayBuffers
1567d88 
Fixes part of #1959.
domenic added a commit that referenced this issue Oct 25, 2016
@domenic
Specify the realm used for WebSocket-created Blobs and ArrayBuffers
6bf5e44 
Fixes part of #1959.
domenic added a commit that referenced this issue Oct 27, 2016
@domenic
Specify the realm for the SSE MessageEvent
e0e4814 
Closes #1959. All other MessageEvents are created as part of "fire an
event", which is covered by whatwg/dom#352.
domenic added a commit that referenced this issue Oct 27, 2016
@domenic
Specify the realm for the SSE MessageEvent
8b68fab 
Closes #1959. All other MessageEvents are created as part of "fire an
event", which is covered by whatwg/dom#352.
@domenic domenic mentioned this issue Oct 27, 2016
Merged
zcorpan pushed a commit that referenced this issue Nov 1, 2016
@domenic @zcorpan
Specify the realm for the SSE MessageEvent
91d19d6 
Closes #1959. All other MessageEvents are created as part of "fire an
event", which is covered by whatwg/dom#352.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@domenic
Specify the realm used for WebSocket-created Blobs and ArrayBuffers
def2ad0 
Fixes part of whatwg#1959.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@domenic
Specify the realm for the SSE MessageEvent
b2dbb8d 
Closes whatwg#1959. All other MessageEvents are created as part of "fire an
event", which is covered by whatwg/dom#352.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
clarification Standard could be clearer topic: events topic: multiple globals
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ms2ger @domenic @bzbarsky @annevk