Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: fix internal cross-reference errors #2098

Merged
merged 2 commits into from
Nov 28, 2016
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Nov 25, 2016

Found while working on whatwg/wattsi#33.

I also took the liberty to remove erroneous title attributes.

#2097 is follow-up.

Found while working on whatwg/wattsi#33.

I also took the liberty to remove erroneous title attributes.

#2097 is follow-up.
@annevk
Copy link
Member Author

annevk commented Nov 25, 2016

We have 14 span elements used for other purposes that I left in place. Those have a class/id/lang attribute and using data-x="" on them wouldn't be a good fit I think.

@@ -50122,13 +50123,13 @@ interface <dfn>HTMLKeygenElement</dfn> : <span>HTMLElement</span> {
same "ASN.1-like" syntax defined by RFC 5280. <ref spec=RFC5280></p>

<pre class="asn"><dfn>PublicKeyAndChallenge</dfn> ::= SEQUENCE {
spki <span>SubjectPublicKeyInfo</span>,
spki <span data-x="">SubjectPublicKeyInfo</span>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the span, here and below?

@@ -48945,7 +48946,7 @@ interface <dfn>HTMLSelectElement</dfn> : <span>HTMLElement</span> {
<dd>Where <span>phrasing content</span> is expected.</dd>
<dt><span data-x="concept-element-content-model">Content model</span>:</dt>
<dd>Either: <span>phrasing content</span>.</dd> <!-- we don't require a <select> element descendant, since there might be zero suggestions -->
<dd>Or: Zero or more <code>option</code> and <span>script-supporting</span> elements.</dd>
<dd>Or: Zero or more <code>option</code> and <span data-x="script-supporting elements">script-supporting</span> elements.</dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the spec is inconsistent about whether it's [script-supporting] elements or [script-supporting elements]. Maybe worth cleaning up in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had [script-supporting elements] first, but then noticed these <dl> boxes were all using [script-supporting] elements. I think it depends on whether or not "elements" is also applicable to something else in the sentence.

@@ -82797,8 +82802,8 @@ State: &lt;OUTPUT NAME=I>1&lt;/OUTPUT> &lt;INPUT VALUE="Increment" TYPE=BUTTON O
<span>top-level browsing context</span>'s <span>document family</span>.</p></li>

<li><p>Append a new entry at the end of the <code>History</code> object representing the new
resource and its <code>Document</code> object, related state, and current history <span>scroll
restoration preference</span>. Its <span>URL</span> must be set to the address to which the user
resource and its <code>Document</code> object, related state, and current history's <span>scroll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this change is correct. It should maybe be the current history entry's scroll restoration mode, but I'm thinking maybe the intent was to have some separate concept of scroll restoration preference which is like a current user preference across the entire browser?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given dd6a34e I doubt it. But maybe @zcorpan or @majido can confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   entry">session history entries</span>. Each <dfn>session history entry</dfn> consists, at a
    minimum, of a <span>URL</span>, and each entry may in addition have a <span>state object</span>, a
 -  title, a <code>Document</code> object, form data, a scroll position, and other information
 -  associated with it.</p>
 +  title, a <code>Document</code> object, form data, a <span>scroll restoration mode</span>, a scroll
 +  position, and other information associated with it.</p>

So it should be <span>current entry</span>'s <span>scroll restoration mode</span>, AFAICT.

@zcorpan zcorpan merged commit 2e7e672 into master Nov 28, 2016
@zcorpan zcorpan deleted the annevk/span-xref branch November 28, 2016 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants