replace "abort these steps" #3152

sam0410 · 2017-10-22T08:24:03Z

Hi, This is for issue number #2878

sam0410 · 2017-10-22T08:25:21Z

source

@@ -1959,7 +1959,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute

     <ol>
      <li><p>If <var>nameList</var> <span data-x="list contains">contains</span> <var>name</var>,
-      reject <var>p</var> with a <code>TypeError</code> and abort these steps.</p></li>
+      reject <var>p</var> with a <code>TypeError</code>.</p></li>


Not sure whether I need to add "return" (same in line 1991)

I think we need to keep "abort these steps" here and that also goes for other algorithms that run "in parallel". You can't really return from those algorithms. At least not as we have currently organized things.

sam0410 · 2017-10-22T08:27:00Z

source

@@ -86602,7 +86595,7 @@ interface <dfn>NavigatorOnLine</dfn> {
   <li><p>If <var>response</var>'s <span data-x="concept-response-type">type</span> is "<code
   data-x="">error</code>", or <var>response</var>'s <span
   data-x="concept-response-status">status</span> is not an <span>ok status</span>, asynchronously
-   complete this algorithm with null, and abort these steps.</p></li>
+   complete this algorithm with null.</p></li>


Not sure whether I need to add "return" (same with line 86800)

annevk

Thanks for taking this on. Found a couple nits.

annevk · 2017-10-25T13:56:00Z

source

@@ -1959,7 +1959,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute

     <ol>
      <li><p>If <var>nameList</var> <span data-x="list contains">contains</span> <var>name</var>,
-      reject <var>p</var> with a <code>TypeError</code> and abort these steps.</p></li>
+      reject <var>p</var> with a <code>TypeError</code>.</p></li>


I think we need to keep "abort these steps" here and that also goes for other algorithms that run "in parallel". You can't really return from those algorithms. At least not as we have currently organized things.

annevk · 2017-10-25T13:56:12Z

source

@@ -1988,7 +1988,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute

     <ol>
      <li><p>If <var>nameList</var> <span data-x="list contains">contains</span> <var>name</var>,
-      reject <var>p</var> with a <code>TypeError</code> and abort these steps.</p></li>
+      reject <var>p</var> with a <code>TypeError</code>.</p></li>


annevk · 2017-10-25T13:58:15Z

source

@@ -120888,7 +120881,6 @@ INSERT INTERFACES HERE
  Stuart Parmenter,
  Subramanian Peruvemba,
  Sudhanshu Jaiswal,
-  sudokus999, <!-- GitHub -->


This seems like a mistake.

annevk · 2017-10-25T13:58:21Z

source

-  Hickson (Google, ian@hixie.ch). More recently, Simon Pieters (no affiliation, Opera until
-  2017-09-15, zcorpan@gmail.com), Anne van Kesteren (Mozilla, annevk@annevk.nl), Philip
-  J&auml;genstedt (Google, philip@foolip.org), and Domenic Denicola (Google, d@domenic.me), all
-  previously long-time contributors, have joined Ian in editing the text directly.</p>


annevk · 2017-10-25T13:59:10Z

source

@@ -100256,8 +100249,8 @@ dictionary <dfn>StorageEventInit</dfn> : <span>EventInit</span> {
   </li>

   <li><p>If the transport layer specifies a character encoding, and it is supported, return that
-   encoding with the <span data-x="concept-encoding-confidence">confidence</span> <i>certain</i>, and
-   abort these steps.</p></li>
+   encoding with the <span data-x="concept-encoding-confidence">confidence</span> <i>certain</i>.


You need to wrap certain to the next line. We don't want to have whitespace before a closing tag.

annevk · 2017-10-25T14:00:09Z

source

@@ -86541,7 +86534,7 @@ interface <dfn>NavigatorOnLine</dfn> {
   <li><p>If <var>response</var>'s <span data-x="concept-response-type">type</span> is "<code
   data-x="">error</code>", or <var>response</var>'s <span
   data-x="concept-response-status">status</span> is not an <span>ok status</span>, asynchronously
-   complete this algorithm with null, and abort these steps.</p></li>
+   complete this algorithm with null.</p></li>


I think we need to keep abort these steps here.

annevk · 2017-10-25T14:00:16Z

source

@@ -86602,7 +86595,7 @@ interface <dfn>NavigatorOnLine</dfn> {
   <li><p>If <var>response</var>'s <span data-x="concept-response-type">type</span> is "<code
   data-x="">error</code>", or <var>response</var>'s <span
   data-x="concept-response-status">status</span> is not an <span>ok status</span>, asynchronously
-   complete this algorithm with null, and abort these steps.</p></li>
+   complete this algorithm with null.</p></li>


annevk · 2017-10-25T14:00:34Z

source

-    <var>moduleMap</var>[<var>url</var>] to null, asynchronously complete this algorithm with null,
-    and abort these steps:</p>
+    <var>moduleMap</var>[<var>url</var>] to null, asynchronously complete this algorithm with null
+    :</p>


And here. (You also cannot break before ":".)

annevk · 2017-10-25T14:01:18Z

source

@@ -87979,7 +87972,7 @@ document.querySelector("button").addEventListener("click", bound);

    <ol>
     <li><p><span>Check if we can run script</span> with <var>job settings</var>. If this returns
-     "do not run" then abort these steps.</p></li>
+     "do not run", then abort these steps.</p></li>


then return*

sam0410 · 2017-10-31T18:07:15Z

Hi @annevk , I made the changes that you suggested.

annevk · 2017-11-01T08:36:20Z

Could you rebase this to resolve the conflicts? I can then have another go at reviewing. I'm sorry that happened by the way.

sam0410 · 2017-11-01T20:21:17Z

in pull request #3185

sam0410 added 2 commits October 22, 2017 13:51

Delete source

bd45acf

remove repetitions

aa45f24

sam0410 commented Oct 22, 2017

View reviewed changes

annevk requested changes Oct 25, 2017

View reviewed changes

sam0410 added 3 commits October 31, 2017 19:28

restore deleted lines

c943d79

restore deleted lines

6fb0613

make suggested changes

3327406

sam0410 closed this Nov 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace "abort these steps" #3152

replace "abort these steps" #3152

sam0410 commented Oct 22, 2017

sam0410 Oct 22, 2017

annevk Oct 25, 2017

sam0410 Oct 22, 2017

annevk Oct 25, 2017

annevk left a comment

annevk Oct 25, 2017

annevk Oct 25, 2017

annevk Oct 25, 2017

annevk Oct 25, 2017

annevk Oct 25, 2017

annevk Oct 25, 2017

annevk Oct 25, 2017

annevk Oct 25, 2017

annevk Oct 25, 2017

sam0410 commented Oct 31, 2017

annevk commented Nov 1, 2017

sam0410 commented Nov 1, 2017

replace "abort these steps" #3152

replace "abort these steps" #3152

Conversation

sam0410 commented Oct 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sam0410 commented Oct 31, 2017

annevk commented Nov 1, 2017

sam0410 commented Nov 1, 2017