Make crossOriginObject.then undefined for promises #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows promises to work better with cross-origin WindowProxy and Location objects. Tests: (please write some). Fixes: whatwg/dom#536.
annevk
commented
Nov 20, 2017
source
Outdated
| @@ -77875,6 +77868,14 @@ console.assert(iframeWindow.frameElement === null); | |||
| </ol> | |||
| </li> | |||
|
|
|||
| <li><p>If <var>P</var> is "<code data-x="">then</code>", <span>@@toStringTag</span>, | |||
| <span>@@hasInstance</span>, or <span>@@isConcatSpreadable</span>, then return | |||
There was a problem hiding this comment.
I noticed a weird thing that above we use SameValue when comparing P but here we make do with "is". Does ECMAScript have some kind of pattern for this that might be better? (Not a new issue though, so not a blocker in my opinion.)
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Nov 23, 2017
According to the discussion (and request) at whatwg/dom#536 this patch adds 'then' as a cross origin accessible property returning 'undefined'. HTML 7.2.3.3 CrossOriginGetOwnPropertyHelper ( O, P ) https://html.spec.whatwg.org/multipage/browsers.html#crossorigingetownpropertyhelper-(-o,-p-) is not yet updated, but it should be quite soon. The proposed change is at whatwg/html#3242 Bug: Change-Id: Icb72ba01ccf8eabaad607b61805411d1b4845f86 Reviewed-on: https://chromium-review.googlesource.com/779319 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518158}
domenic
approved these changes
Dec 1, 2017
domenic
added
normative change
needs tests
|
@domenic I will add some tests in https://bugzilla.mozilla.org/show_bug.cgi?id=1435596 so you should go ahead and merge this. If you wanted to, you could land the test changes from that patch in wpt, I guess, instead of waiting for us to merge them back. I tried running those tests in Chrome, but Chrome seems to fail most of the tests in wpt's html/browsers/origin/cross-origin-objects/cross-origin-objects.html.... It does pass the specific tests I added for Promise.resolve() with cross-origin objects, but not any of the tests about the actual internal methods, because it seems to be doing nothing even resembling what the spec says. :( |
domenic
removed
the
needs tests
kisg
pushed a commit
to paul99/webkit-mips
that referenced
this pull request
Oct 1, 2018
https://bugs.webkit.org/show_bug.cgi?id=190094 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test now that more checks are passing. * web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt: Source/WebCore: Make crossOriginObject.then undefined for promises. This allows promises to work better with cross-origin WindowProxy and Location objects. Specification: - whatwg/html#3242 - whatwg/dom#536 This aligns our behavior with Blink and Gecko. No new tests, rebaselined existing test. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess): (WebCore::addCrossOriginWindowOwnPropertyNames): * bindings/js/JSLocationCustom.cpp: (WebCore::getOwnPropertySlotCommon): (WebCore::addCrossOriginLocationOwnPropertyNames): LayoutTests: Update existing tests to reflect behavior change. * http/tests/navigation/process-swap-window-open-expected.txt: * http/tests/navigation/process-swap-window-open.html: * http/wpt/cross-origin-window-policy/resources/utils.js: (testCrossOriginOption): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@236661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
https://bugs.webkit.org/show_bug.cgi?id=190094 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT test now that more checks are passing. * web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt: Source/WebCore: Make crossOriginObject.then undefined for promises. This allows promises to work better with cross-origin WindowProxy and Location objects. Specification: - whatwg/html#3242 - whatwg/dom#536 This aligns our behavior with Blink and Gecko. No new tests, rebaselined existing test. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess): (WebCore::addCrossOriginWindowOwnPropertyNames): * bindings/js/JSLocationCustom.cpp: (WebCore::getOwnPropertySlotCommon): (WebCore::addCrossOriginLocationOwnPropertyNames): LayoutTests: Update existing tests to reflect behavior change. * http/tests/navigation/process-swap-window-open-expected.txt: * http/tests/navigation/process-swap-window-open.html: * http/wpt/cross-origin-window-policy/resources/utils.js: (testCrossOriginOption): Canonical link: https://commits.webkit.org/205090@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows promises to work better with cross-origin WindowProxy and Location objects.
Tests: (please write some).
Fixes: whatwg/dom#536.
/browsers.html ( diff )