Remove radiusY and rotation from arcTo() method #3371
Conversation
annevk
added
removal/deprecation
|
@junov r? |
source
Outdated
| the point (<var>x0</var>, <var>y0</var>) to the start tangent point by a straight line, adding | ||
| the start tangent point to the subpath, and then connect the start tangent point to the end | ||
| tangent point by <var>The Arc</var>, adding the end tangent point to the subpath.</p></li> | ||
| ellipse that has radius <var>radius</var> on the major and minor axis, and that has one point |
There was a problem hiding this comment.
use "circle" instead of "ellipse", and don't mention major/minor axis.
source
Outdated
| tangent to the half-infinite line that crosses the point (<var>x0</var>, <var>y0</var>) and ends | ||
| at the point (<var>x1</var>, <var>y1</var>), and that has a different point tangent to the | ||
| half-infinite line that ends at the point (<var>x1</var>, <var>y1</var>) and crosses the point | ||
| (<var>x2</var>, <var>y2</var>). The points at which this ellipse touches these two lines are |
|
Thanks, I should have studied the original commit more carefully. I think I got all the places now. |
|
I've made a related change to wpt's interfaces/html.idl in the PR above. From a quick grep, it doesn't look like any tests were using the radius{X,Y} overload, so I guess there's nothing else that needs to be updated there? |
|
Thanks, I forgot about that. I suspect that's it. |
|
Context is that @rakuco and I are looking at a normative spec change without tests every week this quarter to try to understand what's not working well in practice. In this case I think the answer is not to do a careful search for existing tests for unimplemented features, but to auto-sync IDL: web-platform-tests/wpt#7784. And tests for unimplemented features that remain behind will fail everywhere, and we'll have other ways of finding those soon: web-platform-tests/results-collection#83. @mdittmer FYI :) |
They are not implemented.
Partially reverts e25d3f9.
Fixes #878.
/canvas.html ( diff )