Fix toBlob() and convertToBlob() #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular: * Neither method dealt properly with "serialization of a the bitmap as a file" returning null. * Neither method clearly indicated what had to happen synchronously (bitmap copy) and asynchronously (converting to a file). * toBlob() did not indicate the Realm of the new Blob object. * toBlob() invoked IDL's callback concept incorrectly. * convertToBlob() was weird with in parallel and queue a task. * convertToBlob() did not list a task source. Fixes #3386.
junov
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
Fixes #3386.
/canvas.html ( diff )