-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the storage mutex #342
Conversation
@@ -96713,18 +96552,6 @@ dictionary <dfn>StorageEventInit</dfn> : <span>EventInit</span> { | |||
initialised to null. It represents the <code>Storage</code> object that was affected.</p> | |||
|
|||
|
|||
|
|||
<h4>Threads</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this section and point out that there can be racing now that the protection against that is gone? (If we end up specifying something later this can be amended, but it seems good to articulate somewhere the guarantees the specification text offers.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a stern warning for the racy document.cookies
API, and thought I would do something similar for localStorage
once I figure out how to express the "sync at event loop" thing. Do you think we also need to keep this section, or the "Serialisability of script execution" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either is probably fine. I suspect that long term we should rewrite the storage APIs on top of some primitives that define the synchronization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that adding a stern warning + example similar to the coookies one (or maybe just a reference to the cookies example) would be good.
e3e0003
to
d483538
Compare
be thought of as completely serialising the execution of all scripts in all <span data-x="browsing | ||
context">browsing contexts</span>.</p> | ||
|
||
<p class="note">The <code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section is still valuable. You can just remove the note. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
6c901e5
to
bb89fa1
Compare
This LGTM after a rebase. |
bb89fa1
to
1b918cf
Compare
Rebased to resolve conflicts with eec9646 (the removed algorithm released the storage mutex) |
No description provided.