Throw when <OffscreenCanvas> is not usable as image #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junov
approved these changes
Feb 6, 2018
|
Are there plans to update web-platform-tests for this? |
|
Yes the CL that updates wpt is already in flight, right here: https://chromium-review.googlesource.com/c/chromium/src/+/893423 |
|
Awesome! One last thing: @zakerinasab, can you add yourself to the acknowledgments section? See https://github.com/whatwg/html/blob/master/CONTRIBUTING.md#pull-requests |
|
Here is the pull request: #3461
Thanks,
…On Tue, Feb 6, 2018 at 3:44 PM, Domenic Denicola ***@***.***> wrote:
Awesome! One last thing: @zakerinasab <https://github.com/zakerinasab>,
can you add yourself to the acknowledgments section? See
https://github.com/whatwg/html/blob/master/CONTRIBUTING.md#pull-requests
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3453 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AWkMxixT_ILT4rw3WcQnTrDlDAMguXUWks5tSLm8gaJpZM4R6FSE>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for #3398 and sets the behavior of
drawImage when the given source image is an OffscreenCanvas with either width or height of zero to throw an InvalidStateError exception.
/acknowledgements.html ( diff )
/canvas.html ( diff )