Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new concepts 'embedded-ltr' and 'embedded-rtl' for the directionality of an element #4338

Closed
wants to merge 1 commit into from

Conversation

Zhang-Junzhi
Copy link

@Zhang-Junzhi Zhang-Junzhi commented Feb 5, 2019

This patch resolves #3905, the specific explanation is in the git commit message.


/acknowledgements.html ( diff )
/grouping-content.html ( diff )

@fantasai
Copy link
Contributor

fantasai commented Feb 5, 2019

No, this is wrong. That's not how bidi works. Embeddedness is not a directionality.

@Zhang-Junzhi
Copy link
Author

No, this is wrong. That's not how bidi works. Embeddedness is not a directionality.

Embeddedness does change semantics, right?

@Zhang-Junzhi
Copy link
Author

@fantasai You seemed to suggest embeddedness should be a separate notion out of directionality?

Then I guess the spec might mention somewhere else that non-phrasing contents automatically create implicit sembeddedness in bidi semantical sense(like inserting implicit <bdi>). The current spec seems missing it.

…atting

It doesn't make sense to allow bi-di formatting to walk across div.
@Zhang-Junzhi
Copy link
Author

So, here is a much more trivial patch than the previous one.

I think all other non-phrasing content elements(<article>, <p>, ...) already imply bdi-like effects by their names, so I only address it for <div>.

Does the new patch look okay? @fantasai

@fantasai
Copy link
Contributor

fantasai commented Feb 7, 2019

I don't think DIV is anything different than P in this respect. Their bidi effects are both already defined in terms of the 'unicode-bidi: isolate' value, so afaict no change is needed. Basically the combination of https://html.spec.whatwg.org/multipage/rendering.html#bidi-rendering (which defines what's supposed to happen) and https://html.spec.whatwg.org/#requirements-relating-to-the-bidirectional-algorithm (which makes it required for all UAs, not just ones that opt into the Rendering chapter) covers what you're asking for already.

@domenic
Copy link
Member

domenic commented Mar 6, 2019

Closing per @fantasai's latest comment, which I agree with, but happy to continue discussing either here or in #3905.

@domenic domenic closed this Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants