Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CloseEvent in the close event's interface column. #4569

Merged
merged 1 commit into from
May 7, 2019
Merged

Adds CloseEvent in the close event's interface column. #4569

merged 1 commit into from
May 7, 2019

Conversation

ArfatSalman
Copy link
Contributor

@ArfatSalman ArfatSalman commented Apr 25, 2019

Fixes issue #4568
Adds CloseEvent in the close event's interface column.


/acknowledgements.html ( diff )
/indices.html ( diff )

@domenic
Copy link
Member

domenic commented Apr 25, 2019

Thank you!

It looks like you work for https://www.pesto.tech/, which could arguably be "in the field of web technologies". Although @whatwg/sg is still working on giving a more concrete definition of that (whatwg/sg#67), I wonder if your company would be able to sign the agreement as an entity, just to be sure? Otherwise, I'll work on getting the Steering Group to give a more definitive ruling.

@ArfatSalman
Copy link
Contributor Author

I wonder if your company would be able to sign the agreement as an entity, just to be sure?

I'll get them to do it.

Thanks!

PS. So do I have to remove my "individual" details?

@domenic
Copy link
Member

domenic commented Apr 27, 2019

Awesome! Don't worry about removing the individual details; we can take care of it.

@ArfatSalman
Copy link
Contributor Author

Hi @domenic

I've added Pesto Tech as an entity. Here's the ID. "2ee46e73-91a9-49a3-90ca-31bbd14869b2".

@domenic
Copy link
Member

domenic commented May 3, 2019

@ArfatSalman thanks so much! The last step then is to make your membership in the PestoTech GitHub organization public. See https://help.github.com/en/articles/publicizing-or-hiding-organization-membership for instructions.

@ArfatSalman
Copy link
Contributor Author

@domenic Hi. Sorry for the delay. I've made the information public. Let me know the next step.

Thanks for your patience. :)

@domenic domenic merged commit fb79e76 into whatwg:master May 7, 2019
@domenic
Copy link
Member

domenic commented May 7, 2019

Thank you, and congratulations on your first contribution!

@ArfatSalman ArfatSalman deleted the issue-4568 branch May 7, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants