Editorial: uniformize issue references #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
approved these changes
Apr 28, 2019
|
Why not use |
|
Or rename to |
|
Maybe we should stop making XXX fail the build. |
This makes all issue references use links of the form "issue #NNN", or "org/repo issue #NNN". This was the prevailing convention, but there were a few exceptions. Behind the scenes, this also removes the one usage of the "big-issue" CSS class, replacing it with "XXX" (for which it was a stylistic synonym, until whatwg/whatwg.org@36b8b45 removed the "big-issue" styles). It also changes the source from using class="XXX" to using class="XXX"; the former was a workaround for an overzealous lint script, which was fixed in whatwg/html-build#192. Finally, this removes a big commented-out chunk of canvas spec text for fillVerticalText() and strokeVerticalText() methods, which were never implemented.
domenic
changed the title
|
I've renamed and revamped this PR to be a bit more ambitious, with a force-push of a new commit with a detailed commit message. For those reading via email, the summary is that I've also:
Only the first of these is observable to readers of the spec. |
sideshowbarker
approved these changes
May 4, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a synonym for the "XXX" class; we can consolidate around that.
(I'm looking in to whatwg/whatwg.org#187 at the moment.)
/browsers.html ( diff )
/browsing-the-web.html ( diff )
/canvas.html ( diff )
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/infrastructure.html ( diff )
/links.html ( diff )
/offline.html ( diff )
/semantics.html ( diff )
/webappapis.html ( diff )