Remove <iframe seamless> #484
Conversation
| <p class="note">The <code data-x="attr-contenteditable">contenteditable</code> attribute does not | ||
| propagate into <code data-x="attr-iframe-seamless">seamless</code> <code>iframe</code>s.</p> | ||
|
|
||
| <hr> |
There was a problem hiding this comment.
Since this is immediately followed by <hr> <!-- FULLSCREEN -->, we can drop this, no?
There was a problem hiding this comment.
yes, the hr tag right?
There was a problem hiding this comment.
Yes, and perhaps some newlines around it so the amount of spacing between bits of text remains equivalent.
|
This does not yet remove all instances of "explicit self-navigation override". (Since it does remove the definition I would assume it no longer compiles, but I guess it does?) It also has not removed the rendering section rules or the mentions of the attribute in the indexes. |
|
@annevk yes, there is one instance which i have skipped of "explicit self-navigation override", for compiling i didn't got your point. yes the indexes, right removing them. |
| <span>browsing context</span> does not have its <span>seamless browsing context flag</span> set, a | ||
| default value of 8px is expected to be used for that property instead.</p> | ||
|
|
||
| cannot be parsed successfully, then a default value of 8px is expected to be used for that property instead.</p> |
|
@Ritsyy so I think this looks good but it would be good if you updated the commit message to list the dozen or so commits this commit will revert. The addition of seamless was spread over many commits and it would be good to have the commit message point them all out so we can be sure nothing is forgotten. |
|
@annevk yes, i'll add all the commits. |
|
|
||
| <p>For each property in the table below, given a <code>body</code> element, | ||
| the first attribute that exists <span>maps to the pixel length property</ | ||
| span> on the <code>body</code> element. If none of the attributes for a |
There was a problem hiding this comment.
You cannot wrap </span> this way. When running the build script this returns an error.
| <p>The IDL attributes <dfn><code data-x="dom-iframe-src">src</code></dfn>, <dfn><code data-x="dom-iframe-srcdoc">srcdoc</code></dfn>, <dfn><code data-x="dom-iframe-name">name</code></dfn>, <dfn><code data-x="dom-iframe-sandbox">sandbox</code></dfn>, and <dfn><code data-x="dom-iframe-seamless">seamless</code></dfn> must <span>reflect</span> the respective | ||
| content attributes of the same name.</p> | ||
| <p>The IDL attributes <dfn><code data-x="dom-iframe-src">src</code></dfn>, <dfn><code data-x="dom- | ||
| iframe-srcdoc">srcdoc</code></dfn>, <dfn><code data-x="dom-iframe-name">name</code></dfn>, and |
There was a problem hiding this comment.
You cannot wrap inside an attribute value like this. That will cause whitespace to appear there.
Ritsyy
force-pushed
the
Bug331
branch
4 times, most recently
from
61f585e
to
42c9af7
Compare
|
@annevk i have fixed the errors and wrapping issues, committed the changes. Thanks! |
|
@Ritsyy did you also get Could you rebase this on master as well? |
| <p>The IDL attributes <dfn><code data-x="dom-iframe-src">src</code></dfn>, <dfn><code data-x="dom-iframe-srcdoc">srcdoc</code></dfn>, <dfn><code data-x="dom-iframe-name">name</code></dfn>, <dfn><code data-x="dom-iframe-sandbox">sandbox</code></dfn>, and <dfn><code data-x="dom-iframe-seamless">seamless</code></dfn> must <span>reflect</span> the respective | ||
| <p>The IDL attributes <dfn><code data-x="dom-iframe-src">src</code></dfn>, | ||
| <dfn><code data-x="dom-iframe-srcdoc">srcdoc</code></dfn>, <dfn><code data-x="dom-iframe-name">name</code></dfn>, and | ||
| <dfn><code data-x="dom-iframe-sandbox">sandbox</code></dfn> must <span>reflect</span> the respective |
There was a problem hiding this comment.
This is still incorrectly wrapped. Remember, no more than 100 columns per line and you can break after e.g., <dfn><code if that makes the current line longer.
<p>The IDL attributes <dfn><code data-x="dom-iframe-src">src</code></dfn>, <dfn><code
data-x="dom-iframe-srcdoc">srcdoc</code></dfn>, <dfn><code
data-x="dom-iframe-name">name</code></dfn>, and <dfn><code
data-x="dom-iframe-sandbox">sandbox</code></dfn> must <span>reflect</span> the respective content
attributes of the same name.</p>
Is what I get when I follow those guidelines.
Ritsyy
force-pushed
the
Bug331
branch
2 times, most recently
from
c93e2f8
to
f236f62
Compare
Commits Related to it: whatwg@dfa3f22 whatwg@8edfe6d whatwg@9e4f095 whatwg@b0b5d7b whatwg@b3bf8ad whatwg@e5a041e whatwg@cc33290 whatwg@c4d6396 whatwg@f6490f1 whatwg@77e24cd whatwg@0eab1dd whatwg@1782006 whatwg@2898fa9 whatwg@3a6cfaf whatwg@5ae9881 whatwg@f1c0cad whatwg@748113c whatwg@4814a86 whatwg@9dd420c
|
Committed as 1490eba. |
|
You forgot to link to this PR in the commit message. I'm seeing the |
|
Or rather, I guess that the commit message should have linked to #331 |
|
Yeah, apologies, I messed up rather badly. |
1490eba, from PR #484, removed the source browsing context definition along with "explicit self-navigation override". This restores the definition of source browsing context for these elements as it was before that commit. This fixes #1131, but note that per #1130 further changes are required here, as browsing contexts are not a good concept to use as source.
1490eba, from PR #484, removed the source browsing context definition while removing the "explicit self-navigation override". This restores the definition of source browsing context for these elements as it was before that commit. This fixes #1131, but note that per #1130 further changes are required here, as browsing contexts are not a good concept to use as source.
Fix #331
As per http://caniuse.com/#search=seamless , it doesn't seem to be supported.
Hence it is a good candidate for removal.
Commits related to <iframe seamless>:
dfa3f22b5
8edfe6da5
9e4f0956b
b0b5d7b16
b3bf8adba
e5a041ecd
cc33290d6
c4d639680