Set same-origin data-URL flag to <img> fetch request #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --></p> | ||
| <var>image request</var>. Set <span data-x="same-origin-data-url-flag"> | ||
| same-origin data-URL flag</span> on this request instance. | ||
| <!-- TODO "Interaction with the Preload Scanner" from the picture spec--></p> |
There was a problem hiding this comment.
You want to do this somewhere before <!--FETCH-->, similar to how the other things set on <var>request</var> are done. Also, you need to add "same-origin data-URL flag" to the list of terms from Fetch at the start of the specification.
Ritsyy
force-pushed
the
Bug176
branch
2 times, most recently
from
e213e36
to
3b87d8c
Compare
| @@ -24056,10 +24057,13 @@ interface <dfn>HTMLImageElement</dfn> : <span>HTMLElement</span> { | |||
| parent that is a <code>picture</code> element, set <var>request</var>'s <span | |||
| data-x="concept-request-initiator">initiator</span> to "<code data-x="">imageset</code>".</p> | |||
|
|
|||
| <p>⌛ Set <span data-x="same-origin- data-url-flag">same-origin data-URL flag</span> to | |||
| the <span data-x ="concept-fetch">Fetch</span> <var>request</var> instance. | |||
There was a problem hiding this comment.
You can simplify this to Set <var>request</var>'s <span>... flag</span>.
Ritsyy
force-pushed
the
Bug176
branch
3 times, most recently
from
37bd5b7
to
4d0c972
Compare
| @@ -2820,6 +2820,7 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d | |||
| <li><dfn data-noexport="" data-x="concept-request-destination" data-x-href="https://fetch.spec.whatwg.org/#concept-request-destination">destination</dfn> | |||
| <li><dfn data-noexport="" data-x="concept-request-origin" data-x-href="https://fetch.spec.whatwg.org/#concept-request-origin">origin</dfn> | |||
| <li><dfn data-noexport="" data-x-href="https://fetch.spec.whatwg.org/#omit-origin-header-flag">omit-<code>Origin</code>-header flag</dfn> | |||
| <li><dfn data-noexport="" data-x="same-origin-data-url-flag" data-x-href="https://fetch.spec.whatwg.org/#same-origin-data-url-flag">same-origin-data-url-flag</dfn> | |||
There was a problem hiding this comment.
Inside the <dfn>, it should read "same-origin data-URL flag", just like in Fetch. You probably also don't need data-x attribute, although then you'll have to reference the value inside the <dfn> through data-x below (lowercased).
|
@annevk changes done! |
| @@ -2820,6 +2820,7 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d | |||
| <li><dfn data-noexport="" data-x="concept-request-destination" data-x-href="https://fetch.spec.whatwg.org/#concept-request-destination">destination</dfn> | |||
| <li><dfn data-noexport="" data-x="concept-request-origin" data-x-href="https://fetch.spec.whatwg.org/#concept-request-origin">origin</dfn> | |||
| <li><dfn data-noexport="" data-x-href="https://fetch.spec.whatwg.org/#omit-origin-header-flag">omit-<code>Origin</code>-header flag</dfn> | |||
| <li><dfn data-noexport="" data-x-href="https://fetch.spec.whatwg.org/#same-origin-data-url-flag">same-origin data-Url flag</dfn> | |||
There was a problem hiding this comment.
Should be "same-origin data-URL flag" (uppercase "URL")
annevk
pushed a commit
that referenced
this pull request
Jan 19, 2016
|
Committed as b09402f. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #176
Set same-origin data-URL flag to![]()
"Fetch Request's" request instance, otherwise obtained response will be tainted.