Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset window.name also when opener is set to null #5871

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Aug 28, 2020

Helps with #5680.

#5569 might allow for further simplification, but given that #313 is not solved I'm not tackling that here.

We don't have test coverage for session history yet so I haven't made changes there. See also #5679. (This could maybe be folded in if there's no perceived problem with Safari/Firefox's behavior.)

#5350 might obsolete a lot of this, but the specifics haven't really been decided upon yet. It might well make sense to use equivalent logic, but the implications of doing that are bigger:

  1. Agent clusters would be replaced. (Or perhaps they are not guaranteed to survive top-level navigations anyway? I guess it's a bit unclear and might depend on what is in the bfcache.)
  2. The opener browsing context's reference to this browsing context would also be severed.

cc @andypaicu @jakearchibald @rakina @artines1


/browsing-the-web.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and the change is simple. I'll ping the Chromium bug linked in case folks have thoughts; it might be nice to wait a business day or two before merging in case they do.

Also I'll note that the tests as written use BroadcastChannel so we can't really tell if Firefox is proposed to behave the same as Safari or not. Perhaps consider rewriting them to use stash.

Tests: WPT html/browsers/windows/clear-window-name.https.html.

Helps with #5680.
@annevk
Copy link
Member Author

annevk commented Jan 8, 2021

The tests have been updated to use a stash. I forgot about this PR unfortunately, but it still seems good to land now it is rebased. Firefox is about to ship as well (we baked it on Nightly first for a while and found no issues).

Any final thoughts?

@domenic
Copy link
Member

domenic commented Jan 8, 2021

Still looks good. And it seems the tests have made it to wpt.fyi and entirely pass in both Firefox and Safari, so no concerns. https://wpt.fyi/results/html/browsers/windows/clear-window-name.https.html?label=master&label=experimental&aligned

@annevk annevk merged commit 4b6e5ba into master Jan 8, 2021
@annevk annevk deleted the annevk/disowned-auxiliary- branch January 8, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants