Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [EnforceRange] to CanvasImageData mixin methods #6263

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Add [EnforceRange] to CanvasImageData mixin methods #6263

merged 1 commit into from
Jan 9, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Jan 4, 2021 •
edited by pr-preview bot
Loading

This was a change made by Chrome that was reflected in tests, but not in the standard. (See also #2433.)

Closes #4399.

(See WHATWG Working Mode: Changes for more details.)

/canvas.html ( diff )

@annevk
Add [EnforceRange] to CanvasImageData mixin methods
4238f96 
This was a change made by Chrome that was reflected in tests, but not in the standard. (See also #2433.)

Closes #4399.
@emilio
Copy link
Contributor

emilio commented Jan 4, 2021

Firefox patch is https://bugzilla.mozilla.org/show_bug.cgi?id=1684711

domenic
domenic approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the IDL matches Chromium's IDL files.

@annevk
Copy link
Member Author

annevk commented Jan 8, 2021

Maybe @smfr can comment for Safari? (I will file a bug, to be clear.)

@smfr
Copy link

smfr commented Jan 8, 2021

Seems reasonable. Let us know the bug number once you've filed it.

@annevk
Copy link
Member Author

annevk commented Jan 9, 2021

Filed https://bugs.webkit.org/show_bug.cgi?id=220496.

@annevk annevk merged commit b49b9d9 into master Jan 9, 2021
@annevk annevk deleted the annevk/imagedata-enforcerange branch January 9, 2021 08:48
@domenic domenic mentioned this pull request May 4, 2021
Closed
3 tasks
pull bot pushed a commit to FreddyZeng/chromium that referenced this pull request Aug 12, 2021
@yiyix
[OffscreenCanvas] Add EnforceRange to createImageData and putImageData
58d87d0 
The spec change is done here: whatwg/html#6263
and canvasRenderingContext2D has updated. Update the OffscreenCanvas
to reflect the spec change.

Bug: 1068691

Change-Id: Iad944967981fedddd89d795c4d401ef656e14011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3087599
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#911363}
mariospr added a commit to brave/brave-core that referenced this pull request Aug 19, 2021
@mariospr
Adapt to addition of EnforceRange decorator to getImageData() methods
55b452d 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mariospr added a commit to brave/brave-core that referenced this pull request Aug 20, 2021
@mariospr
Adapt to addition of EnforceRange decorator to getImageData() methods
edb83d6 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mariospr added a commit to brave/brave-core that referenced this pull request Aug 20, 2021
@mariospr
Adapt to addition of EnforceRange decorator to getImageData() methods
0743af6 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mkarolin pushed a commit to brave/brave-core that referenced this pull request Aug 26, 2021
@mariospr @mkarolin
Adapt to addition of EnforceRange decorator to getImageData() methods
d300216 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mariospr added a commit to brave/brave-core that referenced this pull request Aug 31, 2021
@mariospr
Adapt to addition of EnforceRange decorator to getImageData() methods
a52f5f8 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mkarolin pushed a commit to brave/brave-core that referenced this pull request Sep 1, 2021
@mariospr @mkarolin
Adapt to addition of EnforceRange decorator to getImageData() methods
4a2de14 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mariospr added a commit to brave/brave-core that referenced this pull request Sep 3, 2021
@mariospr
Adapt to addition of EnforceRange decorator to getImageData() methods
93397b9 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mkarolin pushed a commit to brave/brave-core that referenced this pull request Sep 7, 2021
@mariospr @mkarolin
Adapt to addition of EnforceRange decorator to getImageData() methods
92a8346 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mkarolin pushed a commit to brave/brave-core that referenced this pull request Sep 11, 2021
@mariospr @mkarolin
Adapt to addition of EnforceRange decorator to getImageData() methods
6a7a29d 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mkarolin pushed a commit to brave/brave-core that referenced this pull request Sep 13, 2021
@mariospr @mkarolin
Adapt to addition of EnforceRange decorator to getImageData() methods
659d247 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa

commit 58d87d028a924673703aa8b635669099b045d9aa
Author: Yi Xu <yiyix@chromium.org>
Date:   Thu Aug 12 17:03:13 2021 +0000

    [OffscreenCanvas] Add EnforceRange to createImageData and putImageData

    The spec change is done here: whatwg/html#6263
    and canvasRenderingContext2D has updated. Update the OffscreenCanvas
    to reflect the spec change.

    Bug: 1068691
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@yiyix @copybara-github
[OffscreenCanvas] Add EnforceRange to createImageData and putImageData
d15982a 
The spec change is done here: whatwg/html#6263
and canvasRenderingContext2D has updated. Update the OffscreenCanvas
to reflect the spec change.

Bug: 1068691

Change-Id: Iad944967981fedddd89d795c4d401ef656e14011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3087599
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#911363}
NOKEYCHECK=True
GitOrigin-RevId: 58d87d028a924673703aa8b635669099b045d9aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: canvas
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions getImageData, putImageData and createImageData in CanvasRenderingContext2d should use EnforcedRange
4 participants
@annevk @emilio @smfr @domenic