-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define the autofill pseudo-class. #6273
Conversation
Why is the alias a may? Would any browser not implement it? Is there a test for the alias being done at parse time? And is there a more formal way of defining that? |
It seemed a bit weird to require a WebKit prefix in the HTML spec, it was mostly given as a hint. The alias is somewhat needed for compat right now, but if authors adopt the unprefixed pseudo-class (once implemented everywhere), hopefully eventually it will not. |
If everyone implements it we should require it. We do the same |
Strong +1 for requiring |
Alright, changed it to must, will update the wpt PR as well. |
@@ -68530,6 +68530,15 @@ Demos: | |||
</ul> | |||
</dd> | |||
|
|||
<dt><dfn noexport><code data-x="selector-autofill">:autofill</code></dfn></dt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just do two <dt>
s, one for each selector, so that they're on equal footing?
Also, is there any normative connection we can state with https://html.spec.whatwg.org/#autofill ? It seems like that section is all about the autocomplete=""
processing model, so if user agents autofill values beyond just those annotated, then maybe there is no such connection...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just do two
s, one for each selector, so that they're on equal footing?
Sure, done.
Also, is there any normative connection we can state with https://html.spec.whatwg.org/#autofill ? It seems like that section is all about the autocomplete="" processing model, so if user agents autofill values beyond just those annotated, then maybe there is no such connection...
Yeah, pretty sure autocomplete
is not the only thing that is looked at for form autofill...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed another commit that made them on more equal footing, and also added a note about other sources of autofilling. PTAL to make sure I haven't done anything wrong :).
Looks good, thanks! I'd keep the mention that |
Spec PR at whatwg/html#6273 Tests at web-platform-tests/wpt#27098 Differential Revision: https://phabricator.services.mozilla.com/D101148
Spec PR at whatwg/html#6273 Tests at web-platform-tests/wpt#27098 Differential Revision: https://phabricator.services.mozilla.com/D101148
Spec PR at whatwg/html#6273 Tests at web-platform-tests/wpt#27098 Differential Revision: https://phabricator.services.mozilla.com/D101148 UltraBlame original commit: 28268df8154dad7a2e686ff95ad5559a46316cbf
At least two implementers are interested (and none opposed):
Tests are written and can be reviewed and commented upon at:
Implementation bugs are filed:
(See WHATWG Working Mode: Changes for more details.)
/semantics-other.html ( diff )