-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I made the change and written "User Agent" in place of "UV" in the source file. #6488
Conversation
I updated abbreviation "UV" to "User Agent" in source file
@@ -14458,7 +14458,7 @@ interface <dfn>HTMLMetaElement</dfn> : <span>HTMLElement</span> { | |||
<td><dfn><code data-x="attr-meta-http-equiv-keyword-set-cookie">set-cookie</code></dfn> | |||
<td>Non-conforming | |||
<tr> | |||
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-UA-Compatible</span> | |||
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-User Agent-Compatible</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it valid to redefine HTTP fields? There are some more occurences of such replacement; this is the first one.
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-User Agent-Compatible</span> | |
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-UA-Compatible</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That's indeed incorrect. We should only replace this in prose and we should use "user agent" (lowercase, unless at the start of a sentence) as replacement value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annevk Can you merge my pull request? or I need to make changes in the source file? if any Suggest changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, @arhadthedev pointed out issues with your change, right? And I added to that that we want to use "user agent", lowercase in prose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Atharva-17, thank you! As the bottom part of an issue page says, you need to send a site form, so WHATWG gets legal rights to use your contributions. Technically, that's all that is necessary.
@annevk, is it possible for a member of an organization to squash commits without participation of an author of a pull request? It's necessary for easy analysis and further clean history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annevk @arhadthedev I am getting an error while filling the participant agreement.
And Please guide me stepwise on how to fill participant agreement and sign up for WHATWG.
Please help me out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annevk please help me out !!!!!!
This is my second commit.
I have written a full abbreviation "User Agent" in place of "UV" in the source file.
/dnd.html ( diff )
/dom.html ( diff )
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/history.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/links.html ( diff )
/parsing.html ( diff )
/rendering.html ( diff )
/scripting.html ( diff )
/semantics.html ( diff )
/system-state.html ( diff )
/urls-and-fetching.html ( diff )