Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I made the change and written "User Agent" in place of "UV" in the source file. #6488

Closed
wants to merge 2 commits into from

Conversation

Atharva-17
Copy link

@Atharva-17 Atharva-17 commented Mar 13, 2021

I updated abbreviation "UV" to "User Agent" in source file
@Atharva-17 Atharva-17 changed the title I have written the "User Agent" in place of "UV" in the source file I made the change and written "User Agent" in place of "UV" in the source file. Mar 13, 2021
@@ -14458,7 +14458,7 @@ interface <dfn>HTMLMetaElement</dfn> : <span>HTMLElement</span> {
<td><dfn><code data-x="attr-meta-http-equiv-keyword-set-cookie">set-cookie</code></dfn>
<td>Non-conforming
<tr>
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-UA-Compatible</span>
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-User Agent-Compatible</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid to redefine HTTP fields? There are some more occurences of such replacement; this is the first one.

Suggested change
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-User Agent-Compatible</span>
<td><span data-x="attr-meta-http-equiv-x-ua-compatible">X-UA-Compatible</span>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's indeed incorrect. We should only replace this in prose and we should use "user agent" (lowercase, unless at the start of a sentence) as replacement value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annevk Can you merge my pull request? or I need to make changes in the source file? if any Suggest changes!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, @arhadthedev pointed out issues with your change, right? And I added to that that we want to use "user agent", lowercase in prose.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annevk I made changes in the source file and write "user agent" in lowercase in all the prose.
This is a new commit : 6d612f4
Please check it!.
If everything is right please merge my pull request.
Thank You.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Atharva-17, thank you! As the bottom part of an issue page says, you need to send a site form, so WHATWG gets legal rights to use your contributions. Technically, that's all that is necessary.

@annevk, is it possible for a member of an organization to squash commits without participation of an author of a pull request? It's necessary for easy analysis and further clean history.

Copy link
Author

@Atharva-17 Atharva-17 Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annevk @arhadthedev I am getting an error while filling the participant agreement.
And Please guide me stepwise on how to fill participant agreement and sign up for WHATWG.
Please help me out.

git 2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annevk please help me out !!!!!!

This is my second commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants