-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COEP reporting for workers: fix which variable to use for 'owner' #6525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a bug fix that doesn't change intended behavior. LGTM!
Looks like a relevant test here was added in https://chromium-review.googlesource.com/c/chromium/src/+/2650015 ( Reporting for workers in workers doesn't seem to be covered in that test though. |
cc: @d0iasm |
Test written here: web-platform-tests/wpt#28261 |
Thank you for updating the test and the spec!
Is my understanding correct? |
That matches my understanding, though which document "the document" is depends on how the https://html.spec.whatwg.org/multipage/workers.html#dom-worker
I'll try to submit a test for this today for COEP report for worker, but essentially, the environment settings object that the |
OK, test that exercises "entry environment settings object" vs "incumbent environment settings object" vs "current environment settings object": web-platform-tests/wpt#28313 |
Thanks for going the extra mile on testing!! |
…t' for Worker() URL parsing and COEP report, a=testonly Automatic update from web-platform-tests Test 'current environment settings object' for Worker() URL parsing and COEP report See whatwg/html#6525 -- wpt-commits: 25dba84cf7cae753d192f470d82c457bfcdb4290 wpt-pr: 28313
Fixes #6518
cc @whatwg/cross-origin-isolation
(See WHATWG Working Mode: Changes for more details.)
/workers.html ( diff )