Editorial: factor out and rephrase "can have its URL rewritten" #7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual normative change here is to allow the query component to change in the cross-origin case, not just the fragment component. However, while we're here, we pull out the algorithm into a standalone definition, and rephrase it to be clearer with fewer nested negative conditions. This better aligns with browsers, exactly matching WebKit and being only slightly more lenient than Chromium and Gecko. See the full analysis at #6836 (comment). This also improves the domintro for pushState()/replaceState() to be a bit more in line with modern style, and to explain the error condition. Closes #6836.
annevk
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a dedicated algorithm that underlies whether a URL can be rewritten using history.pushState()/replaceState(). The algorithm is phrased differently, but has the same normative effect, and is clearer since it involves less negatives.
This also adds a table of examples for "can have its URL rewritten", and modernizes and expands the domintros for the pushState() and replaceState() methods.
This is extracted from #6992 and that would be a quick rebase on top of this one.
/history.html ( diff )