Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: fix HTMLScriptElement.supports() for="" value #7043

Merged
merged 1 commit into from Sep 9, 2021
Merged

Meta: fix HTMLScriptElement.supports() for="" value #7043

merged 1 commit into from Sep 9, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 8, 2021 •
edited by pr-preview bot

annevk
annevk approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it weird that this doesn't distinguish between static and non-static? I also would have expected "static method steps" to distinguish it somehow.

@domenic
Copy link
Member Author

domenic commented Sep 9, 2021

Yeah, I thought that was a weird part of the Bikeshed data model.

I like the idea of "static method steps"; we should consider adding that to Web IDL.

@domenic domenic merged commit 7031aba into main Sep 9, 2021
@domenic domenic deleted the fix-supports-for branch September 9, 2021 15:59
@domenic domenic mentioned this pull request Sep 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@domenic @annevk