Note manifest should always be fetched for installed web app #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
This looks good, with some formatting nits I can fix when merging.
Can you make your membership in the GitHub "googlers" organization public, so as to appease the participation checker bot? You can go to https://github.com/orgs/googlers/people?query=
philloooo and change the dropdown to say "Public", not "Private".
|
thanks @domenic for the instruction! Updated and pushed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non normative change to clarify when manifest should be processed for installed web app. Per request from w3c/manifest#1011 (comment)
/links.html ( diff )