Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: fix a couple worklets typos #7220

Closed
wants to merge 1 commit into from
Closed

Editorial: fix a couple worklets typos #7220

wants to merge 1 commit into from

Conversation

Md-Farhan-Jeelani
Copy link

@Md-Farhan-Jeelani Md-Farhan-Jeelani commented Oct 14, 2021 •
edited by pr-preview bot

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:-
    • Chrome: …
    • Firefox: …
    • Safari: …

(See WHATWG Working Mode: Changes for more details.)

/worklets.html ( diff )

@Md-Farhan-Jeelani
Copy link
Author

Checking code

annevk
annevk approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@annevk
Copy link
Member

annevk commented Oct 15, 2021

Wait, something is wrong here. That's @domenic's commit.

@domenic I guess you forgot to create a PR for this?

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Oct 15, 2021
@domenic
Copy link
Member

domenic commented Oct 15, 2021

Ah, yeah, I knew this looked familiar.

@domenic domenic closed this Oct 15, 2021
@domenic domenic added the spam Used on spam pull requests to ensure submitters do not get Hacktober credit label Oct 15, 2021
@annevk annevk deleted the worklets-typos branch October 15, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
do not merge yet Pull request must not be merged per rationale in comment spam Used on spam pull requests to ensure submitters do not get Hacktober credit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Md-Farhan-Jeelani @annevk @domenic