Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the list of activation triggering input events #7248

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Update the list of activation triggering input events #7248

merged 3 commits into from
Nov 1, 2021

Conversation

mustaqahmed
Copy link
Contributor

@mustaqahmed mustaqahmed commented Oct 20, 2021 •
edited by pr-preview bot
Loading

Related to: #3849

  • Removes all high-level events that follow some low-level events.
  • Adds missing low-level events that precede high-level events removed above, or are known to be required for compat reasons (like mousedown).
  • Adds keyboard events in a conditional manner that mostly matches major browsers.
  • At least two implementers are interested (and none opposed): The change is backward compatible for Chrome, Firefox and Safari.
  • Tests have been added/updated through this PR. The latest status of the new tests is available here, see the tests named activation-trigger-*.html.
  • Implementation bugs: Not needed as the change is backward compatible for Chrome, Firefox and Safari.

(See WHATWG Working Mode: Changes for more details.)

/infrastructure.html ( diff )
/interaction.html ( diff )

@mustaqahmed mustaqahmed mentioned this pull request Oct 20, 2021
Closed
domenic
domenic reviewed Oct 20, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great direction and I'm supportive. I wish you best of luck in gathering multi-implementer agreement and tests. In this case the bar I would apply before merging is general agreement that this is an improvement on the current spec (which already has an XXX box saying "The event set is inconsistent across major browsers. See issue #3849."), plus comprehensive tests to the extent possible so that we can lock in the gains here.

source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
source Show resolved Hide resolved
@domenic domenic added interop Implementations are not interoperable with each other normative change topic: user activation labels Oct 20, 2021
@mustaqahmed
Update the list of activation triggering input events.
dbbb071 
- Removed all high-level events that follows a low-level event.
- Added missing low-level events that are known to be required.
- Added keyboard events in a conditinal manner.
@mustaqahmed
domenic's comments.
55f3267
@mustaqahmed
Copy link
Contributor Author

Here is the Chromium CL (under review) that would add matching tests to WPT repository.

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 25, 2021
@mustaqahmed @chromium-wpt-export-bot
Fine-tune wpts for user-activation triggers to match spec proposal.
dfeef79 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Oct 25, 2021
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 25, 2021
@mustaqahmed @chromium-wpt-export-bot
Fine-tune wpts for user-activation triggers to match spec proposal.
433317d 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 25, 2021
@mustaqahmed @chromium-wpt-export-bot
Fine-tune wpts for user-activation triggers to match spec proposal.
cb3349c 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 25, 2021
@mustaqahmed @chromium-wpt-export-bot
Fine-tune wpts for user-activation triggers to match spec proposal.
f518fdc 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242442
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#934619}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 25, 2021
@mustaqahmed @chromium-wpt-export-bot
Fine-tune wpts for user-activation triggers to match spec proposal.
383448b 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 25, 2021
@mustaqahmed @chromium-wpt-export-bot
Fine-tune wpts for user-activation triggers to match spec proposal.
3704e78 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
pull bot pushed a commit to jamlee-t/chromium that referenced this pull request Oct 26, 2021
@mustaqahmed
Fine-tune wpts for user-activation triggers to match spec proposal.
344664a 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242442
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#934619}
@mustaqahmed
Copy link
Contributor Author

@annevk and @eric-carlson: please take a look, I have incorporated all discussion points in the issue.

Tests: We have just landed WPTs. The live status is available here, see the tests named activation-trigger-*.html. The new tests are asserting behavior in a backward compatible way, so they are mostly passing. The tests are facing a technical problem in Safari: requestFullscreen() calls are failing!

@mustaqahmed mustaqahmed mentioned this pull request Oct 26, 2021
Closed
@domenic domenic mentioned this pull request Oct 27, 2021
Closed
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 29, 2021
@mustaqahmed @moz-wptsync-bot
Bug 1737628 [wpt PR 31373] - Fine-tune wpts for user-activation trigg…
38c58ed 
…ers to match spec proposal., a=testonly

Automatic update from web-platform-tests
Fine-tune wpts for user-activation triggers to match spec proposal.

Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0

--

wpt-commits: 3704e78870c66cf9424a1bebfa441198335c002c
wpt-pr: 31373
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Nov 1, 2021
@mustaqahmed @moz-wptsync-bot
Bug 1737628 [wpt PR 31373] - Fine-tune wpts for user-activation trigg…
93cd854 
…ers to match spec proposal., a=testonly

Automatic update from web-platform-tests
Fine-tune wpts for user-activation triggers to match spec proposal.

Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0

--

wpt-commits: 3704e78870c66cf9424a1bebfa441198335c002c
wpt-pr: 31373
annevk
annevk approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

source Show resolved Hide resolved
@domenic domenic merged commit 56071d6 into whatwg:main Nov 1, 2021
@domenic
Copy link
Member

domenic commented Nov 1, 2021

Really great to see this fixed! I love the incremental progress in this area, first with "user activation v2" and then later tightening up the events in this way.

@mustaqahmed mustaqahmed deleted the ua-activation-trigger1 branch November 1, 2021 17:45
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
@mustaqahmed @Gabisampaio
Fine-tune wpts for user-activation triggers to match spec proposal.
9f7fa75 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
@mustaqahmed mustaqahmed mentioned this pull request Nov 18, 2021
Closed
3 tasks
@domenic domenic mentioned this pull request Apr 1, 2022
Closed
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@mustaqahmed
Fine-tune wpts for user-activation triggers to match spec proposal.
11a009c 
Proposed HTML PR: whatwg/html#7248

Manually verified that these tests pass in Firefox.

Change-Id: I910158680a3741290ba9beef2c29050c11763be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3242442
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#934619}
NOKEYCHECK=True
GitOrigin-RevId: 344664adfe08ed7b2bd1a9efb29ffe15f94767d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic left review comments

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
interop Implementations are not interoperable with each other normative change topic: user activation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mustaqahmed @domenic @annevk