Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OffscreenCanvasRenderingContext Notes section #7269

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Update OffscreenCanvasRenderingContext Notes section #7269

merged 3 commits into from
Nov 1, 2021

Conversation

yiyix
Copy link
Contributor

@yiyix yiyix commented Oct 28, 2021 •
edited by pr-preview bot
Loading

The reason for OffscreenCanvasRenderingContext to be an event target was only because Webgl can fire contextlost events at it. After adding contextlost events to OffscreenCanvasRenderingContext2D, OffscreenCanvasRenderingContext has more reasons to be an event target. Updated the spec to reflect this change.

/canvas.html ( diff )

@yiyix yiyix changed the title update OffscreenCanvasRenderingContext notes Update OffscreenCanvasRenderingContext Notes section Oct 28, 2021
@yiyix yiyix mentioned this pull request Oct 28, 2021
Open
domenic
domenic approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits, although @annevk might also want to take a look.

source Show resolved Hide resolved
source Show resolved Hide resolved
meowmix72
meowmix72 approved these changes Oct 30, 2021
View reviewed changes
Copy link

@meowmix72 meowmix72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiyix:updatenotes

annevk
annevk reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable.

Nit: it would make sense if the events were also introduced in the order of 2D first, then WebGL.

@domenic domenic added clarification Standard could be clearer topic: canvas labels Nov 1, 2021
@domenic domenic merged commit 6dad872 into whatwg:main Nov 1, 2021
@yiyix yiyix deleted the updatenotes branch January 4, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@domenic domenic domenic approved these changes

@meowmix72 meowmix72 meowmix72 approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer topic: canvas
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiyix @domenic @annevk @meowmix72