Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment script-blocking style sheet counter when starting to load critical subresources of a <style> #7470

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Increment script-blocking style sheet counter when starting to load critical subresources of a <style> #7470

merged 3 commits into from
Jan 12, 2022

Conversation

xiaochengh
Copy link
Contributor

@xiaochengh xiaochengh commented Jan 7, 2022 •
edited by pr-preview bot
Loading

@xiaochengh
Copy link
Contributor Author

@domenic PTAL

I intentionally left it vague how to fetch the critical subresources, following what we are doing for link. How exactly critical subresources should be fetched and processed are largely unspecified, but fortunately it seems that we don't need to get into it for this particular spec bug.

domenic
domenic requested changes Jan 7, 2022
View reviewed changes
source
<var>element</var>'s <span>node document</span>'s
<span>script-blocking style sheet counter</span> by 1.</p></li>

<li><p>Wait for the style sheet's <span>critical subresources</span> to finish.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this step is a good idea. The caller of this algorithm doesn't do anything after it calls the algorithm, so waiting has no effect.

Instead the appropriate stuff to do after critical subresources finish is handled by the paragraph after this algorithm, starting "Once the attempts to obtain the style sheet's critical subresources, if any, are complete..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean we just merge the paragraph below into this algorithm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just remove this bullet point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

domenic
domenic approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need you to join the googlers organization.

@xiaochengh
Copy link
Contributor Author

Joined

@domenic domenic merged commit 4a73cc6 into whatwg:main Jan 12, 2022
@xiaochengh xiaochengh deleted the issue7469 branch May 3, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with script-blocking <style> elements
2 participants
@xiaochengh @domenic