Process early hints (103 responses) #7675

noamr · 2022-03-03T16:49:25Z

At least two implementers are interested (and none opposed):
- Already implemented in Chromium
- Active work in Mozilla
Tests are written and can be reviewed and commented upon at:
- https://github.com/web-platform-tests/wpt/tree/master/loading/early-hints
Implementation bugs are filed:
- Chrome: Master bug
- Firefox: Early hints master bug
- Safari: No sign of interest yet

(See WHATWG Working Mode: Changes for more details.)

/browsing-the-web.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/links.html ( diff )
/references.html ( diff )
/semantics.html ( diff )

noamr · 2022-03-03T16:58:18Z

FYI @yoavweiss @annevk @bashi @domenic

How it works:

navigation params keeps a list of uncommitted preloads (initially null, reset with cross-origin redirect)
when early hints come from FETCH, those preloads are initiated. The policy container is initialized from the 103 response and the reserved client.
When the document is created, the preload requests are re-checked against the document's policy container, and added to the document's map of preloads. Responses that are already complete are also re-checked with the policy container and reported to resource timing
Responses that come after the document has been created are checked against the document's policy container before being handed off to the consumer.
Timing reported to Resource Timing needs to be coarsened if the new document has a different cross-origin isolated policy from the reserved client.

Early hints provide several interesting race scenarios - we should make sure those scenarios are well WPTed...

yoavweiss · 2022-03-15T10:38:01Z

/cc @ddragana

The HTML/Fetch standards would likely say that preloaded resources are preserved during same origin redirects [1]. Don't clear NavigationEarlyHintsManager to align the discussion. [1] whatwg/html#7675 Bug: 1305896 Change-Id: I410509a8a3a142eb2ef57c5bfb39d2729be84a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3521146 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#981351}

The test page sends an Early Hints with a resource preload. The response of the resource is delayed until the final response consumes the resource. The purpose of this test is to make sure the resource is added to the document's map of preloads [1]. [1] whatwg/html#7675 Bug: 1305896 Change-Id: I39371b41860190936991799fb6457f142e7ffef2

The test page sends an Early Hints with a resource preload. The response of the resource is delayed until the final response consumes the resource. The purpose of this test is to make sure the resource is added to the document's map of preloads [1]. [1] whatwg/html#7675 Bug: 1305896 Change-Id: I39371b41860190936991799fb6457f142e7ffef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545997 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#984778}

The test page sends an Early Hints with a resource preload. The response of the resource is delayed until the final response consumes the resource. The purpose of this test is to make sure the resource is added to the document's map of preloads [1]. [1] whatwg/html#7675 Bug: 1305896 Change-Id: I39371b41860190936991799fb6457f142e7ffef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545997 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#984778}

The test scenarios are: * 103 -> start preload -> preload finished -> 200 -> response body. * 103 -> start preload -> (preload inflight) -> 200 -> preload finished -> response body. The purpose of these tests is to make sure the resource is added to the preload map of the document [1]. Also refer to [2] for the motivation. [1] whatwg/html#7675 [2] #33076 (comment) Bug: 1305896 Change-Id: Id0ba4748f6493bc2c78be6de5769b4d16ce9092f

The test scenarios are: * 103 -> start preload -> preload finished -> 200 -> response body. * 103 -> start preload -> (preload inflight) -> 200 -> preload finished -> response body. The purpose of these tests is to make sure the resource is added to the preload map of the document [1]. Also refer to [2] for the motivation. [1] whatwg/html#7675 [2] web-platform-tests/wpt#33076 (comment) Bug: 1305896 Change-Id: Id0ba4748f6493bc2c78be6de5769b4d16ce9092f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552176 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#985847}

The test scenarios are: * 103 -> start preload -> preload finished -> 200 -> response body. * 103 -> start preload -> (preload inflight) -> 200 -> preload finished -> response body. The purpose of these tests is to make sure the resource is added to the preload map of the document [1]. Also refer to [2] for the motivation. [1] whatwg/html#7675 [2] #33076 (comment) Bug: 1305896 Change-Id: Id0ba4748f6493bc2c78be6de5769b4d16ce9092f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552176 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#985847}

noamr · 2022-03-28T07:54:20Z

@domenic this is ready to be reviewed.

source

domenic · 2022-03-28T19:38:17Z

source

@@ -14270,6 +14274,177 @@ interface <dfn interface>HTMLLinkElement</dfn> : <span>HTMLElement</span> {
     <li><p>Let <var>attribs</var> be <var>linkObject</var>["<code
     data-x="">target_attributes</code>"].</p></li>


This variable is not used.

source

domenic · 2022-03-28T19:53:04Z

source

+    </ol>
+   </li>
+   <li><p>Return <var>links</var>.</p></li>
+  </ol>


Move the XXX box about non-preload link types up to below this algorithm. Or maybe even above it?

source

…ight when consumed, a=testonly Automatic update from web-platform-tests Add WPT for Early Hints preload is in-flight when consumed The test page sends an Early Hints with a resource preload. The response of the resource is delayed until the final response consumes the resource. The purpose of this test is to make sure the resource is added to the document's map of preloads [1]. [1] whatwg/html#7675 Bug: 1305896 Change-Id: I39371b41860190936991799fb6457f142e7ffef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545997 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#984778} -- wpt-commits: 850fd2b4dbf5c21ebb649f6d889caa140b8b29db wpt-pr: 33337

…ad finish timings, a=testonly Automatic update from web-platform-tests Add WPTs for different Early Hints preload finish timings The test scenarios are: * 103 -> start preload -> preload finished -> 200 -> response body. * 103 -> start preload -> (preload inflight) -> 200 -> preload finished -> response body. The purpose of these tests is to make sure the resource is added to the preload map of the document [1]. Also refer to [2] for the motivation. [1] whatwg/html#7675 [2] web-platform-tests/wpt#33076 (comment) Bug: 1305896 Change-Id: Id0ba4748f6493bc2c78be6de5769b4d16ce9092f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552176 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#985847} -- wpt-commits: f88ac14ebaf9206cc08af481c2332b8dbef11a59 wpt-pr: 33365

…ight when consumed, a=testonly Automatic update from web-platform-tests Add WPT for Early Hints preload is in-flight when consumed The test page sends an Early Hints with a resource preload. The response of the resource is delayed until the final response consumes the resource. The purpose of this test is to make sure the resource is added to the document's map of preloads [1]. [1] whatwg/html#7675 Bug: 1305896 Change-Id: I39371b41860190936991799fb6457f142e7ffef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545997 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#984778} -- wpt-commits: 850fd2b4dbf5c21ebb649f6d889caa140b8b29db wpt-pr: 33337

…ad finish timings, a=testonly Automatic update from web-platform-tests Add WPTs for different Early Hints preload finish timings The test scenarios are: * 103 -> start preload -> preload finished -> 200 -> response body. * 103 -> start preload -> (preload inflight) -> 200 -> preload finished -> response body. The purpose of these tests is to make sure the resource is added to the preload map of the document [1]. Also refer to [2] for the motivation. [1] whatwg/html#7675 [2] web-platform-tests/wpt#33076 (comment) Bug: 1305896 Change-Id: Id0ba4748f6493bc2c78be6de5769b4d16ce9092f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552176 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#985847} -- wpt-commits: f88ac14ebaf9206cc08af481c2332b8dbef11a59 wpt-pr: 33365

annevk · 2022-04-07T06:40:09Z

The final commit message here should make clear this ends up closing #7598.

Allow specifications to pass an algorithm to fetch to process 103 Early Hints responses. See whatwg/html#7598 for the overall approach. Corresponding HTML PR: whatwg/html#7675. Co-authored-by: Anne van Kesteren <annevk@annevk.nl>

noamr · 2022-04-11T13:01:41Z

@domenic anything left? I've added examples, and the FETCH PR has landed.

domenic · 2022-04-12T21:52:59Z

Sorry, still digging myself out from the backlog from my week off, but I promise this has made it near the top of the pile.

source

Notably fixing "otherwise false" to be "otherwise 'pre-media'", and linking <link> attributes. Otherwise mostly rewrapping.

The test page sends an Early Hints with a resource preload. The response of the resource is delayed until the final response consumes the resource. The purpose of this test is to make sure the resource is added to the document's map of preloads [1]. [1] whatwg/html#7675 Bug: 1305896 Change-Id: I39371b41860190936991799fb6457f142e7ffef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3545997 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#984778} NOKEYCHECK=True GitOrigin-RevId: 0234f19605f0b7cefa3b6ed6f82c912fa0023595

The test scenarios are: * 103 -> start preload -> preload finished -> 200 -> response body. * 103 -> start preload -> (preload inflight) -> 200 -> preload finished -> response body. The purpose of these tests is to make sure the resource is added to the preload map of the document [1]. Also refer to [2] for the motivation. [1] whatwg/html#7675 [2] web-platform-tests/wpt#33076 (comment) Bug: 1305896 Change-Id: Id0ba4748f6493bc2c78be6de5769b4d16ce9092f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3552176 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#985847} NOKEYCHECK=True GitOrigin-RevId: 071f6139eefcc90470dccbe5d70d8449b58daf12

noamr changed the title ~~Early hints~~ WIP: Early hints Mar 3, 2022

noamr mentioned this pull request Mar 6, 2022

Tests for early hints web-platform-tests/wpt#33076

Closed

16 tasks

noamr force-pushed the early-hints branch from e0f4aaf to e6f2a97 Compare March 16, 2022 07:08

noamr changed the title ~~WIP: Early hints~~ Process early hints (103 responses) Mar 16, 2022

chromium-wpt-export-bot mentioned this pull request Mar 24, 2022

Add WPT for Early Hints preload is in-flight when consumed web-platform-tests/wpt#33337

Merged

chromium-wpt-export-bot mentioned this pull request Mar 25, 2022

Add WPTs for different Early Hints preload finish timings web-platform-tests/wpt#33365

Merged

noamr mentioned this pull request Mar 28, 2022

Interaction of 103 and CSP w3c/preload#114

Closed

domenic added addition/proposal New features or enhancements topic: navigation labels Mar 28, 2022

domenic reviewed Mar 28, 2022

View reviewed changes

noamr force-pushed the early-hints branch 2 times, most recently from 9d7aecc to 5818eee Compare March 31, 2022 14:22

domenic reviewed Mar 31, 2022

View reviewed changes

bashi mentioned this pull request Apr 4, 2022

Process 103 Early Hints response whatwg/fetch#1404

Merged

3 tasks

noamr force-pushed the early-hints branch from 5818eee to db17411 Compare April 4, 2022 16:32

domenic reviewed Apr 13, 2022

View reviewed changes

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

source Outdated Show resolved Hide resolved

source Show resolved Hide resolved

source Show resolved Hide resolved

noamr added 11 commits April 14, 2022 09:40

Process early hints

2157b33

Add note and remove CSP

f2571d6

Remove unnecessary refs

67f0862

Add note about order

dcde6a0

nit

d293fca

nit

e3473d4

Fix build

68f5f9a

Add a couple of more notes

503f06d

Add some more text

2af1aaf

Add explanation and examples for early hints

ce22dca

Fix a few CR nits

5050cf5

noamr force-pushed the early-hints branch from db17411 to 5050cf5 Compare April 14, 2022 06:40

domenic added 2 commits April 14, 2022 11:26

Minor fixes

48cb73b

Notably fixing "otherwise false" to be "otherwise 'pre-media'", and linking <link> attributes. Otherwise mostly rewrapping.

Missing /li

7657f5c

domenic approved these changes Apr 14, 2022

View reviewed changes

domenic merged commit f99550b into whatwg:main Apr 14, 2022

tunetheweb mentioned this pull request Aug 30, 2023

"note about 103 and HTTP/2" makes normative assertion #9637

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Process early hints (103 responses) #7675

Process early hints (103 responses) #7675

noamr commented Mar 3, 2022 •

edited by pr-preview bot

Loading

noamr commented Mar 3, 2022

yoavweiss commented Mar 15, 2022

noamr commented Mar 28, 2022

domenic Mar 28, 2022

domenic Mar 28, 2022

annevk commented Apr 7, 2022

noamr commented Apr 11, 2022

domenic commented Apr 12, 2022

		@@ -14270,6 +14274,177 @@ interface <dfn interface>HTMLLinkElement</dfn> : <span>HTMLElement</span> {
		<li><p>Let <var>attribs</var> be <var>linkObject</var>["<code
		data-x="">target_attributes</code>"].</p></li>

Process early hints (103 responses) #7675

Process early hints (103 responses) #7675

Conversation

noamr commented Mar 3, 2022 • edited by pr-preview bot Loading

noamr commented Mar 3, 2022

yoavweiss commented Mar 15, 2022

noamr commented Mar 28, 2022

domenic Mar 28, 2022

Choose a reason for hiding this comment

domenic Mar 28, 2022

Choose a reason for hiding this comment

annevk commented Apr 7, 2022

noamr commented Apr 11, 2022

domenic commented Apr 12, 2022

noamr commented Mar 3, 2022 •

edited by pr-preview bot

Loading