-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define which elements can be which kinds of widgets for CSS 'appearance' #7839
Define which elements can be which kinds of widgets for CSS 'appearance' #7839
Conversation
This is an editorial rewrite of the prior work by Bocoup (@zcorpan and @howard-e): * whatwg#7004 * w3c/csswg-drafts#6537 Co-authored-by: fantasai <fantasai.bugs@inkedblade.net> Co-authored-by: Simon Pieters <zcorpan@gmail.com> Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good on an editorial level. @zcorpan, would you be able to confirm this preserves the desired semantics?
<span>native appearance</span> <span data-x="widget">widgets</span>, and defines whether to use that <span>native | ||
appearance</span> depending on the <span>'appearance'</span> property. That logic, in | ||
turns, depends on whether on whether each the element is classified as a <span>devolvable | ||
widget</span>, or <span>non-devolvable widget</span>. This section defines which elements match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra comma
meter { appearance: auto; }</code></pre> | ||
|
||
<p>The <code>meter</code> element whose <span>native appearance</span> is a <span>devolvable | ||
widget</span>. Its expected <span>native appearance</span> is to render as an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the sentence "The meter element whose native appearance is a devolvable widget" makes sense? Is there a missing/extra word? Same for progress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be
<p>The <code>meter</code> element is a <span>devolvable widget</span>.
…ins for 'appearance', a=testonly Automatic update from web-platform-tests HTML: Test transition and animation origins for 'appearance' Follows whatwg/html#7839 and w3c/csswg-drafts#7230 -- wpt-commits: 541e49a74546de0128524f7e97906d24b3cfdefa wpt-pr: 25439
…ins for 'appearance', a=testonly Automatic update from web-platform-tests HTML: Test transition and animation origins for 'appearance' Follows whatwg/html#7839 and w3c/csswg-drafts#7230 -- wpt-commits: 541e49a74546de0128524f7e97906d24b3cfdefa wpt-pr: 25439
This is an editorial rewrite (by @fantasai and myself) of the prior work by @zcorpan and @howard-e:
Goal: avoid having to talk about specific HTML elements in the CSS spec, and in particular, avoid having to have long lists of types of widgets there.
Doing that was undesirable because:
The resulting spec is much more straightforward and much shorter, so we think this is a better approach, and this was accepted by the CSSWG (including @zcorpan). The CSS part has been landed.
This HTML part is complete in the sense that it works with the CSS part, but like the original PR from @zcorpan, lacks details about the rendering of each type of widgets. I'd expect the HTML folks to keep iterating from there, as with the previous incarnation of this PR.
This change is making the spec align more closely with what is already implemented. Chromium and Gecko have already implemented most of the changes here, and have minor bugs to iron out.
[css-ui-4] Provide hooks for HTML to define rendering for widgets w3c/csswg-drafts#7224
(See WHATWG Working Mode: Changes for more details.)
/index.html ( diff )
/infrastructure.html ( diff )
/rendering.html ( diff )