Define which elements can be which kinds of widgets for CSS 'appearance' #7839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an editorial rewrite of the prior work by Bocoup (@zcorpan and @howard-e): * whatwg#7004 * w3c/csswg-drafts#6537 Co-authored-by: fantasai <fantasai.bugs@inkedblade.net> Co-authored-by: Simon Pieters <zcorpan@gmail.com> Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
domenic
reviewed
Apr 21, 2022
| <span>native appearance</span> <span data-x="widget">widgets</span>, and defines whether to use that <span>native | ||
| appearance</span> depending on the <span>'appearance'</span> property. That logic, in | ||
| turns, depends on whether on whether each the element is classified as a <span>devolvable | ||
| widget</span>, or <span>non-devolvable widget</span>. This section defines which elements match |
| meter { appearance: auto; }</code></pre> | ||
|
|
||
| <p>The <code>meter</code> element whose <span>native appearance</span> is a <span>devolvable | ||
| widget</span>. Its expected <span>native appearance</span> is to render as an |
There was a problem hiding this comment.
I don't think the sentence "The meter element whose native appearance is a devolvable widget" makes sense? Is there a missing/extra word? Same for progress?
There was a problem hiding this comment.
I think it should be
<p>The <code>meter</code> element is a <span>devolvable widget</span>.
zcorpan
reviewed
Apr 25, 2022
zcorpan
approved these changes
Apr 25, 2022
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 5, 2022
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 16, 2022
…ins for 'appearance', a=testonly Automatic update from web-platform-tests HTML: Test transition and animation origins for 'appearance' Follows whatwg/html#7839 and w3c/csswg-drafts#7230 -- wpt-commits: 541e49a74546de0128524f7e97906d24b3cfdefa wpt-pr: 25439
14 tasks
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
May 25, 2022
…ins for 'appearance', a=testonly Automatic update from web-platform-tests HTML: Test transition and animation origins for 'appearance' Follows whatwg/html#7839 and w3c/csswg-drafts#7230 -- wpt-commits: 541e49a74546de0128524f7e97906d24b3cfdefa wpt-pr: 25439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an editorial rewrite (by @fantasai and myself) of the prior work by @zcorpan and @howard-e:
Goal: avoid having to talk about specific HTML elements in the CSS spec, and in particular, avoid having to have long lists of types of widgets there.
Doing that was undesirable because:
The resulting spec is much more straightforward and much shorter, so we think this is a better approach, and this was accepted by the CSSWG (including @zcorpan). The CSS part has been landed.
This HTML part is complete in the sense that it works with the CSS part, but like the original PR from @zcorpan, lacks details about the rendering of each type of widgets. I'd expect the HTML folks to keep iterating from there, as with the previous incarnation of this PR.
This change is making the spec align more closely with what is already implemented. Chromium and Gecko have already implemented most of the changes here, and have minor bugs to iron out.
[css-ui-4] Provide hooks for HTML to define rendering for widgets w3c/csswg-drafts#7224
(See WHATWG Working Mode: Changes for more details.)
/index.html ( diff )
/infrastructure.html ( diff )
/rendering.html ( diff )