Improve clarity of render-blocking related terms #7870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found this PR necessary for doing further work on the Fetch PR. So PTAL, thanks! |
3 tasks
domenic
approved these changes
May 3, 2022
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 27, 2022
This this the implementation-side follow-up of the spec change: whatwg/html#7870 Bug: 1271296 Change-Id: I77f91437c000301f7dcc0bb60f5b6f6011f7e48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669845 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1008322}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This this the implementation-side follow-up of the spec change: whatwg/html#7870 Bug: 1271296 Change-Id: I77f91437c000301f7dcc0bb60f5b6f6011f7e48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669845 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1008322} NOKEYCHECK=True GitOrigin-RevId: e53ee9d0e4f7357adb998bf9d270f7cb610081dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an editorial change. The original definition of "render-blocking" can be confusing because it's mostly reflecting the
blockingattribute's value, and as a result, a render-blocking element may actually have never blocked rendering.This PR revises the terms so that:
(This is currently a draft PR. I'm also working on the Fetch spec to add render-blocking information to
Requestobjects, which may depend on this PR)/dom.html ( diff )
/indices.html ( diff )
/links.html ( diff )
/scripting.html ( diff )
/semantics.html ( diff )
/urls-and-fetching.html ( diff )