Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: use <iframe>, not <object>, for content-venn.svg #8026

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Editorial: use <iframe>, not <object>, for content-venn.svg #8026

merged 1 commit into from
Jul 6, 2022

Conversation

domenic
Copy link
Member

@domenic domenic commented Jun 22, 2022 •
edited by pr-preview bot
Loading

Helps with #4592.

/dom.html ( diff )

@domenic domenic requested a review from zcorpan July 6, 2022 06:53
zcorpan
zcorpan approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zcorpan zcorpan merged commit 30c8f34 into main Jul 6, 2022
@zcorpan zcorpan deleted the dont-use-object branch July 6, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
topic: embed and object
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @zcorpan