Introduce FocusOptions.focusVisible. #8087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Jul 8, 2022
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 11, 2022
As per: * whatwg/html#7830 * whatwg/html#8087 Replace the internal preventFocusRing with the new flag. Differential Revision: https://phabricator.services.mozilla.com/D151326 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1765083 gecko-commit: 570b38756541697f8b5c3b8084b5a2fb438eeca9 gecko-reviewers: smaug, pip-reviewers
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 12, 2022
As per: * whatwg/html#7830 * whatwg/html#8087 Replace the internal preventFocusRing with the new flag. Differential Revision: https://phabricator.services.mozilla.com/D151326
domenic
reviewed
Jul 12, 2022
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 12, 2022
As per: * whatwg/html#7830 * whatwg/html#8087 Replace the internal preventFocusRing with the new flag. Differential Revision: https://phabricator.services.mozilla.com/D151326 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1765083 gecko-commit: 570b38756541697f8b5c3b8084b5a2fb438eeca9 gecko-reviewers: smaug, pip-reviewers
domenic
approved these changes
Jul 13, 2022
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Jul 15, 2022
As per: * whatwg/html#7830 * whatwg/html#8087 Replace the internal preventFocusRing with the new flag. Differential Revision: https://phabricator.services.mozilla.com/D151326
7 tasks
13 tasks
|
It is not the same, it does allow preventing it. |
|
Thanks for the fast response @emilio, I'm glad. Maybe the wording is a bit ambiguous? It only mentions what should happen when it's |
|
The wording is rather clear IMO: "If it's true or not present but matches heuristic, indicate focus.". Thus, if it's explicitly false, you wouldn't indicate focus. But if you or @domenic have suggestions for clarification then those would be welcome :) |
|
Totally right @emilio, my brain is not working too well today. :) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7830
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/interaction.html ( diff )