Edited the 'state state' typo and added Nereida Rondon to contributor… #8349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
requested changes
Oct 3, 2022
|
I also signed the Participation Form. 🤗 |
domenic
reviewed
Oct 4, 2022
| @@ -40359,7 +40359,7 @@ interface <dfn interface>HTMLAreaElement</dfn> : <span>HTMLElement</span> { | |||
| must be the radius of the circle, again in <span data-x="'px'">CSS pixels</span>.</p> | |||
|
|
|||
| <p>In the <dfn attr-value for="area/shape" data-x="attr-area-shape-default">default state</dfn> | |||
| state, <code>area</code> elements must not have a <code data-x="attr-area-coords">coords</code> | |||
There was a problem hiding this comment.
The comma needs to stay on the previous line so that there's not a visible space between "default state" and the comma :)
There was a problem hiding this comment.
😅 Sorry... fixed.
There was a problem hiding this comment.
It doesn't look fixed to me, looking at https://github.com/whatwg/html/pull/8349/files ... perhaps you forgot to push?
There was a problem hiding this comment.
Just pushed again, I think the first time I didn't push to the correct branch maybe.
There was a problem hiding this comment.
Thanks, but now there is a trailing extra space at the end of line 40361! The build will fail if there is trailing space. Could you remove that?
|
Thank you! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… list in source.
Editorial fix issue ticket - Typo in section "4.8.13 The area element" #8346
I deleted the second 'state' (see below) and added my name to list of contributors at the end of the source file.
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/image-maps.html ( diff )