Editorial: fix usage of processResponseConsumeBody #8412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Oct 20, 2022
nicolo-ribaudo
force-pushed
the
proper-processResponseConsumeBody
branch
from
97445cf
to
07fb2c0
Compare
domenic
reviewed
Oct 23, 2022
|
I added a commit to also fix the signature for synchronous fetching, by removing synchronous fetching (since it's not supported anymore) and pausing while waiting for the result of a normal fetch. Since there is now a single type of fetch, I reverted part of #8328: there is now again a single "perform the fetch" hook type, which accepts a callback that takes response and bytes. This is exactly how it works for the default fetch. |
domenic
reviewed
Oct 28, 2022
|
Done! I also updated w3c/ServiceWorker#1658, since I already had that PR open, and I would appreciate also a review on that side even if you are not the maintainer of that spec (but the changes are very similar to the changes in this PR). |
nicolo-ribaudo
added a commit
to nicolo-ribaudo/manifest
that referenced
this pull request
Oct 28, 2022
This commit implements the HTML changes done in whatwg/html#8412: "processing a manifest" takes a response whose body has been already consumed, so it needs to take the body bytes as a separate parameter.
marcoscaceres
added a commit
to w3c/manifest
that referenced
this pull request
Oct 31, 2022
This commit implements the HTML changes done in whatwg/html#8412: "processing a manifest" takes a response whose body has been already consumed, so it needs to take the body bytes as a separate parameter. Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
domenic
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #7996.
I didn't updatesynchronous perform the fetchsteps, because I couldn't find what's the signature of Fetch when using it synchronously.TODO:
bodyBytesinstead of trying to readresponse's body. chore: update "processing a manifest"'s signature w3c/manifest#1058/infrastructure.html ( diff )
/links.html ( diff )
/semantics.html ( diff )
/webappapis.html ( diff )
/workers.html ( diff )
/worklets.html ( diff )