Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow blocking=render on rel preload & modulepreload #8621

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Disallow blocking=render on rel preload & modulepreload #8621

merged 1 commit into from
Jan 10, 2023

Conversation

NiedziolkaMichal
Copy link
Contributor

@NiedziolkaMichal NiedziolkaMichal commented Dec 14, 2022 •
edited by pr-preview bot
Loading

Removes information about blocking attribute being possible to be set, when rel attribute is preload or modulepreload. It is part of #7935 and fixes #8550.

/semantics.html ( diff )

@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Dec 14, 2022
Merged
@NiedziolkaMichal
Copy link
Contributor Author

@xiaochengh Could you review this PR, please?

xiaochengh
xiaochengh approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@xiaochengh xiaochengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-owner LGTM

@domenic

domenic
domenic approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry this fell into the editors' holiday breaks!

@domenic domenic added document conformance impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation labels Jan 10, 2023
@domenic domenic merged commit d58f35f into whatwg:main Jan 10, 2023
@NiedziolkaMichal
Copy link
Contributor Author

Thanks for the review

@YusukeHirao YusukeHirao mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaochengh xiaochengh xiaochengh approved these changes

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
document conformance impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blocking=render in preload and modulepreload links
3 participants
@NiedziolkaMichal @domenic @xiaochengh