Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8364isssue-solved #8781

Closed
wants to merge 1 commit into from
Closed

#8364isssue-solved #8781

wants to merge 1 commit into from

Conversation

YASHWANTHKESAGONI
Copy link

@YASHWANTHKESAGONI YASHWANTHKESAGONI commented Jan 26, 2023 •
edited by pr-preview bot
Loading

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …

(See WHATWG Working Mode: Changes for more details.)

/webappapis.html ( diff )

@YASHWANTHKESAGONI
Copy link
Author

Please can you review my changes?

domenic
domenic requested changes Jan 26, 2023
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo all changes to the review-drafts files first.

@YASHWANTHKESAGONI
Copy link
Author

@domenic I am new to the open-source. I didn't get you.

@domenic
Copy link
Member

domenic commented Jan 26, 2023

That's ok. This project might be a bit too advanced, in that case.

@YASHWANTHKESAGONI YASHWANTHKESAGONI marked this pull request as draft January 26, 2023 13:10
@YASHWANTHKESAGONI
Copy link
Author

YASHWANTHKESAGONI commented Jan 26, 2023 •
edited
Loading

I think I did it now.

@YASHWANTHKESAGONI
Copy link
Author

@domenic I will try hard on this issue. Please figure out the issue that I did.

@YASHWANTHKESAGONI YASHWANTHKESAGONI marked this pull request as ready for review January 27, 2023 15:48
@YASHWANTHKESAGONI YASHWANTHKESAGONI marked this pull request as draft January 27, 2023 15:49
@domenic domenic closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YASHWANTHKESAGONI @domenic