Clean up popover focusing steps #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepharhar
reviewed
Mar 8, 2023
webkit-commit-queue
pushed a commit
to nt1m/WebKit
that referenced
this pull request
Mar 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=253231 rdar://106132025 Reviewed by Ryosuke Niwa. https://html.spec.whatwg.org/#popover-focusing-steps PR open here to update the popover focusing steps: whatwg/html#8998 The remaining failures are due to new dialog focusing steps being not implemented yet (TBD in https://bugs.webkit.org/show_bug.cgi?id=250795) * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-child-dialog-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-expected.txt: * Source/WebCore/dom/Element.cpp: (WebCore::autoFocusDelegate): (WebCore::Element::findFocusDelegateForTarget): (WebCore::Element::findAutofocusDelegate): * Source/WebCore/dom/Element.h: * Source/WebCore/html/HTMLElement.cpp: (WebCore::runPopoverFocusingSteps): (WebCore::HTMLElement::showPopover): Canonical link: https://commits.webkit.org/261400@main
nt1m
force-pushed
the
cleanup-popover-focusing-steps
branch
from
cc031fd
to
3f306b4
Compare
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 14, 2023
This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with additional code in GetAutofocusDelegate. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0
annevk
reviewed
Mar 15, 2023
nt1m
force-pushed
the
cleanup-popover-focusing-steps
branch
from
3f306b4
to
3cb3aca
Compare
nt1m
force-pushed
the
cleanup-popover-focusing-steps
branch
from
3cb3aca
to
ef727d8
Compare
annevk
approved these changes
Jun 8, 2023
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 21, 2023
This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with additional code in GetAutofocusDelegate. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 22, 2023
This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with a call to GetAutofocusDelegate. This removes support for a use case where the popover is a shadow host with delegatesFocus, but after discussing this doesn't seem like an important use case. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 22, 2023
This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with a call to GetAutofocusDelegate. This removes support for a use case where the popover is a shadow host with delegatesFocus, but after discussing this doesn't seem like an important use case. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336167 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1161492}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 22, 2023
This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with a call to GetAutofocusDelegate. This removes support for a use case where the popover is a shadow host with delegatesFocus, but after discussing this doesn't seem like an important use case. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336167 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1161492}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 22, 2023
This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with a call to GetAutofocusDelegate. This removes support for a use case where the popover is a shadow host with delegatesFocus, but after discussing this doesn't seem like an important use case. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336167 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1161492}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 6, 2023
Automatic update from web-platform-tests Refactor popover initial focus This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with a call to GetAutofocusDelegate. This removes support for a use case where the popover is a shadow host with delegatesFocus, but after discussing this doesn't seem like an important use case. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336167 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1161492} -- wpt-commits: 9aa7d07db6ed3423e1df099a7f7e048b59549b82 wpt-pr: 38994
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 7, 2023
Automatic update from web-platform-tests Refactor popover initial focus This patch removes the autofocus_only parameter from GetFocusDelegate and replaces it with a call to GetAutofocusDelegate. This removes support for a use case where the popover is a shadow host with delegatesFocus, but after discussing this doesn't seem like an important use case. This is being changed in the spec here: whatwg/html#8998 Bug: 1307772 Change-Id: Id7b92d467492030f4a9226ad3f5ae0a10f1896e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336167 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1161492} -- wpt-commits: 9aa7d07db6ed3423e1df099a7f7e048b59549b82 wpt-pr: 38994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8994
html/semantics/popovers/focus-*(See WHATWG Working Mode: Changes for more details.)
/interaction.html ( diff )
/popover.html ( diff )