Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: change "show popover" to call "check popover validity" first #9439

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Editorial: change "show popover" to call "check popover validity" first #9439

merged 3 commits into from
Jun 29, 2023

Commits on Jun 19, 2023

  1. Change "show popover" to call "check popover validity" first 

    This is what implementations (at least Gecko and Chromium) do and it's analogous to
what happens in "hide popover".

Fixes whatwg#9429.
    @mbrodesser-Igalia
    mbrodesser-Igalia committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    25edd1c View commit details
    Browse the repository at this point in the history

  2. Define "cleanupShowingFlag" in "show popover" after defining "nestedS… 

    …how"

Simplifies understanding the spec.
    @mbrodesser-Igalia
    mbrodesser-Igalia committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    1126390 View commit details
    Browse the repository at this point in the history

  3. Start new line earlier so that . isn't at the line's end 

    Otherwise, the rendered page would contain a space character after the
`.`.
    @mbrodesser-Igalia
    mbrodesser-Igalia committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    0edd08f View commit details
    Browse the repository at this point in the history