Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the directionality account for missing parent element #9554

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Make the directionality account for missing parent element #9554

merged 6 commits into from
Aug 29, 2023

Commits on Aug 24, 2023

  1. Make the directionality account for missing parent element 

    The current algorithm has no defined exit for when an element has no parent element and its dir attribute is in the undefined state.

And also rewrite it to make it easier to change as we want to account for shadow trees in a future version.

This was inspired by work from Brian Kardell and fantasai in this area.

Closes #9452.
    @annevk
    annevk committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ddabf6b View commit details
    Browse the repository at this point in the history

  2. review

    @annevk
    annevk committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c8e1c31 View commit details
    Browse the repository at this point in the history

  3. CI

    @annevk
    annevk committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    5797c62 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. review

    @annevk
    annevk committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6af292a View commit details
    Browse the repository at this point in the history

  2. review

    @annevk
    annevk committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ab453a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. final nit

    @annevk
    annevk committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    50f3d25 View commit details
    Browse the repository at this point in the history