Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: change <ref> syntax #9575

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Meta: change <ref> syntax #9575

merged 2 commits into from
Aug 6, 2023

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 2, 2023

Although <ref> is nonstandard HTML, which is somewhat reasonable for build tools to use, requiring a nonstandard HTML parser for the build tools is kind of bad.


The two commits in this PR were generated by:

  1. Regexp replacing <ref[\s\n]+spec="?([^">]+)"?> with <ref>$1</ref>
  2. Running specfmt.

Merging this PR is delicate. I think the sequence will be:

I can do all this, once the appropriate approvals are lined up. I'll be sure to carve aside an hour or two in case anything goes wrong and we need to revert.


💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Aug 6, 2023, 10:28 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

Parsing MDN data...
Parsing...
Parse Error: (800,83) unexpected end tag



If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@domenic domenic merged commit c97651a into main Aug 6, 2023
1 check failed
@domenic domenic deleted the ref-tags branch August 6, 2023 10:34
@domenic
Copy link
Member Author

domenic commented Aug 6, 2023

I think the sequence will be:

For future reference, this did not work, because whatwg/html's CI relies on the GitHub Container Registry image for whatwg/html-build, which is only updated after successfully merging the html-build PR.

I had to resort to a sequence involving merging various PRs with failing CI, and then re-running the CIs after everything was merged.

But, it's all working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants