Queue toggle events and dialog close with microtasks #9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Sep 26, 2023
| @@ -82801,8 +82799,8 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> { | |||
| <p>Every <span data-x="HTML elements">HTML element</span> has a <dfn>popover showing or | |||
| hiding</dfn>, which is a boolean, initially set to false.</p> | |||
|
|
|||
| <p>Every <span data-x="HTML elements">HTML element</span> <dfn>popover toggle task tracker</dfn>, | |||
| which is a <span>toggle task tracker</span> or null, initially null.</p> | |||
| <p>Every <span data-x="HTML elements">HTML element</span> has a <dfn>popover toggle task | |||
There was a problem hiding this comment.
Should this be microtask tracker?
annevk
reviewed
Sep 26, 2023
| @@ -59918,8 +59918,7 @@ interface <dfn interface>HTMLDetailsElement</dfn> : <span>HTMLElement</span> { | |||
| </li> | |||
|
|
|||
| <li> | |||
| <p><span>Queue an element task</span> given the <span>DOM manipulation task source</span> and | |||
| <var>element</var> to run the following steps:</p> | |||
| <p><span>Queue a microtask</span> to run the following steps:</p> | |||
There was a problem hiding this comment.
We should pass in a document here and elsewhere. (No need to pass in an event loop.)
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9046
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )
/popover.html ( diff )