Fix PromiseRejectionEvent's promise attribute #9897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discovered in whatwg/streams#1298 (comment), Promise<T> is actually not an appropriate type for it.
domfarolino
approved these changes
Dec 8, 2023
| data-x="">Promise<<var>T</var>></code> types always wrap the input into a new promise, the | ||
| <code data-x="dom-PromiseRejectionEvent-promise">promise</code> attribute is of type <code | ||
| data-x="idl-object">object</code> instead, which is more appropriate for representing an opaque | ||
| handle to the original promise object.</p> |
There was a problem hiding this comment.
I don't know if it is more appropriate to link to https://webidl.spec.whatwg.org/#idl-promise where you write "promise" or not, but I noticed you did do that for "object" in this same note. (Of course "promise" is more conversational than "object" anyways.)
There was a problem hiding this comment.
I think linking Promise<T> would be reasonable, but "promise" isn't connected enough to that definition.
I'll file another editorial issue for linking Promise<T> globally.
annevk
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in whatwg/streams#1298 (comment), Promise is actually not an appropriate type for it.
/webappapis.html ( diff )