Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UA styles rather than prose to define <input> clip. #9994

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Dec 15, 2023

The previous prose to make overflow act as visible with regards to other CSS features but still clip didn't work well with e.g. text-overflow: ellipsis. CSS now has a standard way to do what input buttons need, i.e. clip and also not affect interaction with vertical-align.

Fixes #9976.


💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Dec 18, 2023, 8:10 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

error code: 524

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@emilio emilio requested a review from zcorpan December 15, 2023 10:45
@emilio
Copy link
Contributor Author

emilio commented Dec 15, 2023

@mfreed7 fyi, I realized I also need to use overflow-clip-margin to preserve behavior properly.

@mfreed7
Copy link
Contributor

mfreed7 commented Dec 15, 2023

@mfreed7 fyi, I realized I also need to use overflow-clip-margin to preserve behavior properly.

Yeah, that seems reasonable.

Copy link
Contributor

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zcorpan
Copy link
Member

zcorpan commented Dec 18, 2023

I'd say this doesn't need an MDN update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[forms] Make <input type=button> magic clip not magic
4 participants