-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define "user agent". #269
Define "user agent". #269
Conversation
This definition draws from previous definitions in RFC 2616, https://www.w3.org/TR/UAAG20/#def-user-agent, https://www.w3.org/TR/CSS2/conform.html#user-agent, and https://en.wikipedia.org/wiki/User_agent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. I'm a bit unsure about the "for example" connector, but probably it's the best way to go.
Let's leave this open for a bit more discussion, I suppose?
s/for example/such as/ ? |
Merge this after TPAC when there's no more feedback? |
@@ -97,6 +97,11 @@ violation. | |||
either width or height is zero"), means an inclusive "or" (implying "or both"), unless it is called | |||
out as being exclusive (with "but not both"). | |||
|
|||
<p>A <dfn export>user agent</dfn> is any software that acts on behalf of a user, for example by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p>A <dfn export>user agent</dfn> is any software that acts on behalf of a user, for example by | |
<p>A <dfn export>user agent</dfn> is any software that acts on behalf of a user; for example by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interwebs say to use a semicolon here (and a comma after) when the second bit is a complete sentence, which it isn't here. I don't feel strongly, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interwebs say to use a semicolon here (and a comma after) when the second bit is a complete sentence, which it isn't here. I don't feel strongly, of course.
I don’t feel strongly about it either — so it’s fine by me to leave it as-is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think s/for example/such as/ is a better approach.
I kept it as "for example by" since "such as by" seemed awkward to me. Different approaches welcome though as follow-up PRs. |
This definition draws from previous definitions in RFC 2616,
https://www.w3.org/TR/UAAG20/#def-user-agent,
https://www.w3.org/TR/CSS2/conform.html#user-agent, and
https://en.wikipedia.org/wiki/User_agent.
I am not at all tied to the particular wording of this definition or the choice of specification it appears in. If it moves to HTML, it can probably be more specific, maybe along the lines of https://www.w3.org/TR/CSS2/conform.html#user-agent.
Fixes whatwg/html#1021.
Preview | Diff