Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data structures #7

Merged
merged 6 commits into from
Nov 7, 2016
Merged

Add data structures #7

merged 6 commits into from
Nov 7, 2016

Conversation

domenic
Copy link
Member

@domenic domenic commented Nov 5, 2016

Closes #4.

@domenic domenic mentioned this pull request Nov 5, 2016
@annevk
Copy link
Member

annevk commented Nov 7, 2016

This is really great!

  • We need to decide whether any of these contains values or elements.
  • We their size.
  • A sequence should just be a list, no?
  • Inside "map", instead of saying "append", should we use "add to the end of the map" since that's the internal terminology we use for lists?

@annevk
Copy link
Member

annevk commented Nov 7, 2016

By the way, feel free to merge this once we decide what they contain (values or elements) and use that consistently.

And maybe the map thing. Sequence <> list can be follow-up.

@domenic
Copy link
Member Author

domenic commented Nov 7, 2016

Yeah those make sense.

I'm also wondering if ordered sets should become a type of list, given that that's the plan for stacks/queues as well.

@annevk
Copy link
Member

annevk commented Nov 7, 2016

I would be okay with that. I was also wondering if we could have more polymorphous behavior to avoid duplicating all prose.

@domenic
Copy link
Member Author

domenic commented Nov 7, 2016

Yeah. Will fix the easy things and then file follow-up issues and try to address them.

@domenic domenic merged commit 9351644 into master Nov 7, 2016
@domenic domenic deleted the data-structures branch November 7, 2016 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants