Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix header capitalization congruence #50

Merged
merged 3 commits into from
Nov 9, 2017
Merged

Editorial: Fix header capitalization congruence #50

merged 3 commits into from
Nov 9, 2017

Conversation

snuggs
Copy link
Member

@snuggs snuggs commented Nov 8, 2017

@annevk
Copy link
Member

annevk commented Nov 8, 2017

Hmm, I think it should be "WHATWG GitHub Labels" (or maybe just "GitHub Labels"; the prefixing with WHATWG is rather arbitrary), given that it's also "Code of Conduct" on https://whatwg.org/code-of-conduct.

@snuggs
Copy link
Member Author

snuggs commented Nov 8, 2017

I thought "Headers are sentence cased" @annevk? Methinks you are inferring single # is the "Title" and ##... are "Headers". Am I correct? Nonetheless, I concur about WHATWG prefix.

Removed in 81a410d as per your request.

@annevk
Copy link
Member

annevk commented Nov 9, 2017

Yeah, sorry for being vague. A single # is the "title" (that matches the style on whatwg.org anyway).

@snuggs
Copy link
Member Author

snuggs commented Nov 9, 2017

@annevk copy that!

Fixed in 3e6f355

Also took the liberty to rebase atop our most recent patches in master.

We should be good to go on this one. Much more to do 😎

@annevk annevk merged commit 3400d2c into whatwg:master Nov 9, 2017
@annevk
Copy link
Member

annevk commented Nov 9, 2017

Thanks!

@snuggs snuggs deleted the issue/48-header-capitalization-congruence branch November 9, 2017 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants