Add top-level site to storage key. (#127) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Jun 3, 2022
wanderview
force-pushed
the
dev-sk-top-site
branch
from
8ec1c23
to
4187d31
Compare
wanderview
force-pushed
the
dev-sk-top-site
branch
from
4187d31
to
eb6c32a
Compare
|
Its unclear to me if this PR is something we are comfortable merging into the spec now or not. Do we have adequate consensus on using top-level site for partitioning? My sense is we have at least two engines between chromium and gecko, but there are still some differences to webkit (ephemeral 3rd party storage). |
|
I think that only affects how long the storage is kept, not how it's keyed, right? It seems to me that all browsers want to align on this keying. |
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Jun 15, 2022
This is technically not a normative change right now, but it will be when whatwg/storage#144 lands.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff