Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notate abstract ops that can throw #371

Closed
domenic opened this issue Jul 2, 2015 · 2 comments
Closed

Notate abstract ops that can throw #371

domenic opened this issue Jul 2, 2015 · 2 comments
Assignees
@domenic
Labels
editorial Changes that do not affect how the standard is understood.

Comments

@domenic
Copy link
Member

domenic commented Jul 2, 2015

#366 was a good first step in making the flow of potential exceptions clearer in the spec. We should also consider notating whether an abstract operation can throw or not so that callers know whether to use perform or to handle any abrupt completions.

Here's an approach:
Sample screenshot hacked together with web inspector
@domenic domenic added the editorial Changes that do not affect how the standard is understood. label Jul 2, 2015
@domenic domenic self-assigned this Jul 2, 2015
@domenic domenic mentioned this issue Jul 2, 2015
Closed
@tyoshino
Copy link
Member

tyoshino commented Jul 2, 2015

Looks good

@domenic domenic mentioned this issue Jul 6, 2015
Closed
@rwaldron
Copy link

This will be super helpful

domenic added a commit that referenced this issue Aug 3, 2015
@domenic
Notate throwing vs. non-throwing abstract operations
ead1a56 
Fixes #371.
@domenic domenic mentioned this issue Aug 3, 2015
Merged
domenic added a commit that referenced this issue Aug 5, 2015
@domenic
Notate throwing vs. non-throwing abstract operations
c062c3b 
Fixes #371.
domenic added a commit that referenced this issue Aug 5, 2015
@domenic
Notate throwing vs. non-throwing abstract operations
2684999 
Fixes #371.
domenic added a commit that referenced this issue Aug 5, 2015
@domenic
Notate throwing vs. non-throwing abstract operations
43a49ab 
Fixes #371.
domenic added a commit that referenced this issue Aug 5, 2015
@domenic
Notate throwing vs. non-throwing abstract operations
427b762 
Fixes #371.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
editorial Changes that do not affect how the standard is understood.
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwaldron @domenic @tyoshino